Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 385987

Summary:

Hidden tabs' filenames should be bolded in "Show List" drop-down of tabbed editor view.

Product:

[Eclipse Project] Platform

Reporter:

Michael Mangino <mangino>

Component:

Assignee:

Paul Webster <pwebster>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

akafakir, blessedgeek, bournenoir, daniel_megert, emoffatt, griefsong, harvananz, markus.kell.r, mauromol, pwebster, wim.jongman

Version:

4.2

Keywords:

helpwanted

Target Milestone:

4.4 M1

Hardware:

OS:

Windows 7

Whiteboard:

patch

Bug Depends on:

Bug Blocks:

411503

Attachments:

Description	Flags
"Show List" screenshot in Indigo. Shows correct bolding of hidden tabs.	none
"Show List" screenshot in Juno. Shows non-bolding of hidden tabs.	none

Description Michael Mangino

2012-07-25 17:08:22 EDT

Build Identifier: Version: Juno Release Build id: 20120614-1722

When so many files are being edited that all tabs cannot be shown, a double-arrow icon appears to the right of the right-most tab, along with a number indicating the number of hidden tabs. When clicking this icon, a drop-down is displayed showing all files open in that tab group. Prior to Juno, the hidden tabs' filenames appeared in bolded text in this list. However, in Juno, the hidden tabs' filenames are not bolded.

Having the hidden entries bolded is a very nice usability feature because it allows the user to easily see the groups of hidden and visible files that are open.

Reproducible: Always

Steps to Reproduce:
1. Open enough files that some of their tabs become hidden.
2. Click on the "Show List" double-arrow icon to the right of the right-most visible file tab.
3. Note that the hidden files' names are not bolded.

Comment 1 Michael Mangino

2012-07-25 17:10:26 EDT

Created attachment 219188 [details]
"Show List" screenshot in Indigo. Shows correct bolding of hidden tabs.

Comment 2 Michael Mangino

2012-07-25 17:11:00 EDT

Created attachment 219189 [details]
"Show List" screenshot in Juno. Shows non-bolding of hidden tabs.

Comment 3 Mauro Molinari

2012-10-28 14:00:39 EDT

I agree with this request and I also opened bug #393002 to provide an option to restore the MRU editor tabs visibility policy of Eclipse 3.x!

Comment 4 Paul Webster

2012-11-12 10:33:43 EST

*** Bug 394104 has been marked as a duplicate of this bug. ***

Comment 5 Dave

2012-12-03 16:13:31 EST

This problem has been bugging (no pun intended) me ever since I switched to Juno. It's especially annoying if the files either have identical names or begin with the same words: SomeJavaClassModel.java and SomeJavaClassModelEditor.java and the tab only shows "SomeJavaClass..." while the expanded list does not tell me which one I'm looking at and which one's hidden.

Comment 6 Markus Keller

2013-05-17 11:22:06 EDT

*** Bug 408153 has been marked as a duplicate of this bug. ***

Comment 7 Leonid Ripeynih

2013-05-21 14:07:42 EDT

Here is proposed fix

https://git.eclipse.org/r/13031
Please, review.

Comment 8 Paul Webster

2013-06-24 11:12:16 EDT

Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c4a0a191c68de406d3c8ea8202a8e8a1fb58bdbd

Thanks Leonid.

Also http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5fedb27bd48bb9aecfc9cd63649fc6188c61e210 to update a test.

PW

Comment 9 Dani Megert

2013-06-25 08:19:51 EDT

The bundle version was not updated in both bundles.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d2800a3e2efc4b9ed32933efa6a569862a8ab49c

Comment 10 Eric Moffatt

2013-08-07 10:44:39 EDT

Verified in 4.4.0.I20130806-2000.

Comment 11 Dani Megert

2013-08-12 08:53:14 EDT

Verified in 4.4 M1.

We should revisit the usage of bold for hidden items though, see bug 70982.