Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 385661

Summary:	[historyView] Find: doesn't show
Product:	[Technology] EGit	Reporter:	Stephan Herrmann <stephan.herrmann>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	CLOSED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	robin, ruth, twolf
Version:	2.0
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Stephan Herrmann

2012-07-21 08:44:17 EDT

This is on Linux, not sure if other platforms have the same issue:

I can't find a way to navigate to a specific commit in the history view.


Using the "Find:" field, I see some jumping in the history view, like its telling me: "I found it". But the highlighted position is not shown.

When I manually scroll to the correct position, I can see that it is indeed highlighted, but for that I have to know that position in the first place :-/

According to bug 324737 comment 3 scrolling is implemented, but from that comment I'm not quite sure, if it is hooked to the Find: field at all?

Could it be a matter of the size of the history? I'm seeing this when working on JDT/Core, which has *many* commits in its history :)


Additionally, bug 360868 suggests to use "Git search" then "Show in > History", but for me "Show in" only offers "Properties".


In this particular case I was using "Find:" only, to locate the head of a given branch. The same would be much easier, if the Repositories view offered "Show In > History" for a branch. Haven't search, whether that's been requested yet.

Comment 1 Robin Stocker

2012-07-25 06:25:35 EDT

Can confirm this (also on Linux), the reveal on find seems to be broken.

Interesting experiment:

Search for "e" in commit message (matches many commits). Then click on "Next" repeatedly. Now as further down as you get, the more off the scroll position seems to be.

For the first result that is not in the already shown commits, it's only about one commit off. Then for the next, it scrolls one down when revealing and is still just one off. Then the further down, the more off.

There is also some noticeable flickering going on in the first two columns when just jumping between the newest two commits using "Next" and "Previous".

Comment 2 Ruth Alkema

2012-10-22 06:40:28 EDT

I can also confirm this.  I can add that this used to work, I don't know exactly when it stopped working.

As in the initial description, I also see some jumping in the history view, I also see the first highlighted commit, just for a moment. But then the view jumps to some other place

Comment 3 Ruth Alkema

2012-10-22 11:03:02 EDT

I think it probably has to do with this bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=338696

I could fix the issue if I changed around line 170 in CommitGraphTable, I removed SWT.VIRTUAL and SWT.MULTI, and after that the selection works, although it still
looks a bit jumpy.  You then see the history page scroll up and down quickly, but in the end it is at the correct position.

I think the SWT.VIRTUAL is probably there for a reason, so it is probably not a good solution to remove it, but perhaps this is helpful information to pinpoint exactly what is the problem.

Comment 4 Stephan Herrmann

2012-10-22 17:45:43 EDT

Sometimes I observe a phenomenon that may or may not be related:
History quickly oscillates between different positions, making it impossible to read anything, or click & focus any specific commit.

Unfortunately, I don't have steps for reproducing (yet). Last time I saw it it was after requesting blame annotations and selecting commits via annotations in the gutter.

Comment 5 Thomas Wolf

2017-05-03 09:19:23 EDT

Cannot reproduce. Guess it's been fixed in the last five years :-)