Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 385420

Summary: double-click to open System editor and default editor problem
Product: [Tools] Target Management Reporter: David McKnight <dmcknigh>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: batthish, xuanchen
Version: 3.4Flags: xuanchen: review+
Target Milestone: 3.4.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 385426    
Attachments:
Description Flags
patch to check for external editor and reset default editor after download none

Description David McKnight CLA 2012-07-18 11:31:06 EDT 
Open With->System editor works while double-click to open the system editor is no longer working.
Comment 1 David McKnight CLA 2012-07-18 11:54:48 EDT 
Also, in SystemEditableRemoteFile, the _usingDefaultDescriptor should get reset to false after the call to IDE.getEditorDescriptor(file) is made with an actual resource so that future calls to the SystemEditableRemoteFile don't ignore explicit descriptors.
Comment 2 David McKnight CLA 2012-07-18 12:29:43 EDT 
Created attachment 218881 [details]
patch to check for external editor and reset default editor after download
Comment 3 David McKnight CLA 2012-07-18 12:30:33 EDT 
Xuan, could you please review this patch?
Comment 4 David McKnight CLA 2012-07-18 17:01:17 EDT 
The default editor problem may be the same as this:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=383588
Comment 5 Xuan Chen CLA 2012-07-19 15:31:35 EDT 
The fix looks good.  Thanks.
Comment 6 David McKnight CLA 2012-07-19 16:29:50 EDT 
Thanks for the review, Xuan.  I've committed the change to the HEAD stream.
Comment 7 David McKnight CLA 2012-07-20 10:56:36 EDT 
Forgot to mark this as fixed.
Comment 8 David McKnight CLA 2012-07-24 12:09:04 EDT 
*** Bug 383588 has been marked as a duplicate of this bug. ***
Comment 9 Martin Oberhuber CLA 2012-09-19 10:12:54 EDT 
Fixing target milestone