Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 384874

Summary: CBI SWT build delivers strange artifacts
Product: [Eclipse Project] Platform Reporter: Andrey Loskutov <loskutov>
Component: SWTAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: P3 CC: andrea.ross, gheorghe, krzysztof.daniel, pwebster, Silenio_Quarti, thanh.ha
Version: 4.2.1   
Target Milestone: 4.2.2   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 372792, 377115    
Attachments:
Description Flags
Fix for bundle size
none
Fix a typo in Krzysztof's patch none

Description Andrey Loskutov CLA 2012-07-11 16:59:24 EDT 
Build Identifier: 

Original report: 
http://dev.eclipse.org/mhonarc/lists/cbi-dev/msg00474.html
http://dev.eclipse.org/mhonarc/lists/cbi-dev/msg00484.html

It looks like SWT build is not optimal yet: AFAIK SWT maintains their own very special build and version schema, and so the generated jar has wrong version/content (see http://dev.eclipse.org/mhonarc/lists/cbi-dev/pngAamYF9SsuX.png): 

"3.8 from eclipse.org": 
org.eclipse.swt_3.8.0.v3833.jar 18 KB 

"3.8 custom": 
org.eclipse.swt_3.8.0.201207061258.jar 7.2 MB 

However this seems not break the UI (after quick smoke test).

Also I've noticed that the content of SWT sources/native plugin/fragment differs from the "default" SWT artifacts.

Reproducible: Always
Comment 1 Krzysztof Daniel CLA 2012-07-17 09:57:00 EDT 
thanks for this report. I'll look into this.
Comment 2 Krzysztof Daniel CLA 2012-07-19 07:51:21 EDT 
Created attachment 218917 [details]
Fix for bundle size

The org.eclipse.swt is just a pure shell, and it should not include classes nor other binaries. Fortunately, this can be easily fixed :-)
Comment 3 Paul Webster CLA 2012-09-21 07:23:03 EDT 
In the latest build, I still see this problem:
-rw-rw-r--. 1 pwebster eclipseUI 7523469 Sep 20 22:35 org.eclipse.swt_3.100.1.v20120912-1609.jar

-rw-rw-r--. 1 pwebster eclipseUI  517843 Sep 20 22:35 org.eclipse.swt.gtk.linux.x86_64_3.100.1.v20120912-1823.jar
Comment 4 Paul Webster CLA 2012-09-21 07:26:00 EDT 
In this state, my eclipse can't load SWT

!ENTRY org.eclipse.equinox.ds 4 0 2012-09-21 07:24:47.506
!MESSAGE [SCR] Exception while activating instance org.eclipse.e4.ui.css.swt.internal.theme.ThemeEngineManager@685bb81a of component org.eclipse.e4.ui.css.swt.theme  
!STACK 0
java.lang.NoClassDefFoundError: org.eclipse.swt.widgets.Display


PW
Comment 5 Paul Webster CLA 2012-10-23 13:45:39 EDT 
(In reply to comment #2)
> Created attachment 218917 [details]
> Fix for bundle size

I applied the fix and re-ran the build.

the bundle looks much better, but the CBI version is missing the plugin.properties file and the PDE version contains it.

PW
Comment 6 Paul Webster CLA 2012-10-24 11:30:10 EDT 
Created attachment 222728 [details]
Fix a typo in Krzysztof's patch

Specify what's included in org.eclipse.swt
Comment 7 Paul Webster CLA 2012-10-24 11:31:46 EDT 
This is for 4.2.2 and 3.8.2 streams

PW
Comment 8 Silenio Quarti CLA 2012-10-24 11:46:36 EDT 
Is there any reason to include oldnotes_swt.html? It is not included in the p2 build.
Comment 9 Paul Webster CLA 2012-10-24 11:51:25 EDT 
You're right, that doesn't need to be in there.  Could you just remove that line?

PW
Comment 11 Silenio Quarti CLA 2012-10-24 12:10:37 EDT 
One more question: is the .api_description file included somehow?
Comment 12 Paul Webster CLA 2012-10-24 12:55:10 EDT 
(In reply to comment #11)
> One more question: is the .api_description file included somehow?

Not yet, that's bug 381057

PW
Comment 13 Grant Gayed CLA 2013-01-08 11:27:38 EST 
Closing report since SSQ pushed the change to 3.8.2/4.2.2 in comment 10.