Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 383810

Summary:	ISharedImages.IMG_DEC_FIELD_ERROR has no image
Product:	[Eclipse Project] Platform	Reporter:	Paul Webster <pwebster>
Component:	UI	Assignee:	Eric Moffatt <emoffatt>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	contact, lafeuil, Lars.Vogel, marcelo.paternostro, mcraquel, remy.suen, sbernard, stolz+bugzilla, tjbishop, webmaster
Version:	3.6
Target Milestone:	4.2.2
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	304397
Bug Blocks:

Description Paul Webster

2012-06-28 10:29:59 EDT

This change needs to be merged into 4.x

+++ This bug was initially created as a clone of Bug #304397 +++

Build Identifier: 

The API call PlatformUI.getWorkbench().getSharedImages().getImage(ISharedImages.IMG_DEC_FIELD_ERROR) returns null.  Looking back at bug 262173 it looks like an image was not added for both the error (ISharedImages.IMG_DEC_FIELD_ERROR) and warning (ISharedImages.IMG_DEC_FIELD_WARNING) overlay image.  Could the images icons/full/ovr16/error_co.gif and icons/full/ovr16/warning_co.gif from the org.eclipse.jdt.ui bundle be copied into org.eclipse.ui and used for PlatformUI's shared images?

Reproducible: Always

Comment 1 Troy Bishop

2012-11-13 15:38:21 EST

Is it possible to target the fix for this problem in the 4.2.2 stream?  The product I work on uses this decorator icon (since it was added in 3.6 via bug 304397) and as a result of it not being in the 4.2 stream it is regressing the functionality where we use it.

Comment 2 Eric Moffatt

2012-11-13 16:04:19 EST

Paul, how did this regress ? Did we cut over to GIT before I committed the other fix ?

If so maybe we should add this to my 4.2.2 list ??

Comment 3 Paul Webster

2013-01-11 14:23:33 EST

Troy, I've pushed up the declaration of the shared images in http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=d4866fb6a161a3970141e6faa2510147a77e3e05

Could you check that this is the fix you need when the next M build comes out at http://download.eclipse.org/eclipse/downloads (probably Wed, Jan 16th by about 3 p.m.)

PW

Comment 4 Paul Webster

2013-01-11 14:24:31 EST

Comment 5 Troy Bishop

2013-01-14 10:23:05 EST

(In reply to comment #3)
> Troy, I've pushed up the declaration of the shared images in
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?h=R4_2_maintenance&id=d4866fb6a161a3970141e6faa2510147a77e3e05
> 
> Could you check that this is the fix you need when the next M build comes
> out at http://download.eclipse.org/eclipse/downloads (probably Wed, Jan 16th
> by about 3 p.m.)
> 
> PW

I pulled the source for o.e.u.workbench and I can confirm now that your change fixes the problem... I'll double check once the binary builds are available as well.

Comment 6 Eric Moffatt

2013-01-17 13:18:59 EST

Verified as per Tony's comment...