Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 38349

Summary: wizard description showing border and caret
Product: [Eclipse Project] Platform Reporter: Grant Gayed <grant_gayed>
Component: SWTAssignee: Grant Gayed <grant_gayed>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jeffmcaffer, Kevin_Haaland, matt, n.a.edgar, Silenio_Quarti, snorthov, Tod_Creasey, wassim.melhem
Version: 2.1Keywords: accessibility
Target Milestone: ---   
Hardware: PC   
OS: Linux-Motif   
Whiteboard:
Bug Depends on:    
Bug Blocks: 37277    
Attachments:
Description Flags
current wizard appearance in 2.1.1
none
2.1.1 wizard with Text border fix from 3.0 stream applied none

Description Grant Gayed CLA 2003-06-02 17:54:43 EDT
2.1.1 candidate (Monday June 2nd), all motif platforms

Open any wizard and you'll notice that the description text at the top has a, 
etched border and a caret.  This has been introduced to 2.1.1 by a UI-level 
change that exposes an swt bug; the description widget used to be a Label, but 
has been changed to a Text.  Attached is what this looks like.

A fix for Text borders already exists in the 3.0 stream, so it could be put 
into the 2.1.1 stream to make the etched border go away.  Attached is what this 
would then look like; the leading caret is the remaining ugliness.

So should the swt Text border fix go in to 2.1.1, or should the UI revert its 
Label widget to Text widget change?
Comment 1 Grant Gayed CLA 2003-06-02 17:56:01 EDT
Created attachment 5031 [details]
current wizard appearance in 2.1.1
Comment 2 Grant Gayed CLA 2003-06-02 17:56:37 EDT
Created attachment 5032 [details]
2.1.1 wizard with Text border fix from 3.0 stream applied
Comment 3 Steve Northover CLA 2003-06-02 19:45:17 EDT
Kevin and/or Nick, you need to force this or we won't make the change as it's 
a bit late in 2.1.1 to make changes (unless you think it's important).  The 
fix is not very dangerous ... but it is late in the release cycle, no?
Comment 4 Steve Northover CLA 2003-06-04 15:05:12 EDT
Jeff, this one was not on the list but Nick and Kevin are on the PR so they 
have been informed.  Basically, we can fix this easily or this will be 
automatically fixed if the UI puts back the Label widget instead of the Text 
widget in the wizards.
Comment 5 Jeff McAffer CLA 2003-06-04 17:32:26 EDT
There appear to be a number of problems with changing the label to a text 
widget.  In this scenario it does not seem to get much value and makes for some 
hokey behaviour.  Nick advises that changing back is easy.  I suggest that we 
investigate that path.
Comment 6 Nick Edgar CLA 2003-06-05 09:56:40 EDT
Tod, looks like we should back out of this since it causes unexpected layout 
and appearance changes on Motif.  While it would have been nice to improve 
accessibility here, there is no strong requirement to do so for 2.1.1.

Comment 7 Tod Creasey CLA 2003-06-05 10:06:18 EDT
If the computeSize fix is not going into 2.1.1 then we can back out but if it 
is the problem will be fixed. 
Comment 8 Felipe Heidrich CLA 2003-06-05 10:48:03 EDT
Tod, the fix for the computeSize you refer (Bug#38213) was released yesterday in
the R2_1_maintenance branch.

Comment 9 Grant Gayed CLA 2003-06-05 10:49:12 EDT
Although the computeSize change is in, we're not sure at this point about 
putting the motif Text border change into 2.1.1 (contrary to my previous 
comment, sorry).  We would prefer to have the UI change reverted.
Comment 10 Tod Creasey CLA 2003-06-05 13:55:43 EDT
We will back out of the change for 2.1.1 but it will remain in the current 
integration stream.
Comment 11 Matthew King CLA 2003-06-11 13:54:28 EDT
For accessibility, we need a caret so that the user of an assistive technology 
can arrow through the contents of the field. It is OK if the caret is not 
visible as long as screen magnifiers know that the focus is on that field via 
MSAA. Screen reader and screen magnifier users need the caret to arrow through 
the field to spell/see individual words, etc. in the event the error text is 
not easily understood when spoken or viewed as a whole.
Comment 12 Tod Creasey CLA 2003-07-30 14:53:28 EDT
This is released in the 3.0 stream.
Comment 13 Tod Creasey CLA 2004-12-08 10:33:21 EST
*** Bug 80464 has been marked as a duplicate of this bug. ***