Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 383263

Summary: [unifyprofiling] Provide profiling types for plug-ins to contribute towards under "Profile As"
Product: [Tools] Linux Tools Reporter: Roland Grunberg <rgrunber>
Component: ProjectAssignee: Roland Grunberg <rgrunber>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, cabernal, jjohnstn
Version: unspecified   
Target Milestone: 2.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 273872    
Attachments:
Description Flags
Mockup of launcher
none
Launch Configuration Tab Group none

Description Roland Grunberg CLA 2012-06-21 13:20:22 EDT
This bug is intended to track the progress of the Profiling Unification work for the project. More information on this effort can be viewed here  at http://wiki.eclipse.org/Linux_Tools_Project/Profiling/Unification.

Basically the purpose is to hide away the implementation details of the underlying tools used as much as possible. This is so that a user doesn't need to know what tool is being used, but rather that they can profile memory, time, or snapshots of time, etc.

This work is being done on master and will affect mostly org.eclipse.linuxtools.profiling.launch . In addition it may require the creation of a few additional plugins (that will provide the various profiling types). The goal is to minimize the amount of work needed by individual plugins.
Comment 1 Alexander Kurtakov CLA 2012-06-22 05:00:32 EDT
Created attachment 217732 [details]
Mockup of launcher
Comment 2 Alexander Kurtakov CLA 2012-06-22 05:03:51 EDT
The attached mockup is how I see the unified launcher being represented.
A really simple first tab giving you just the possibility to choose the backend and set some common variables/paths (if it makes sense). Depending on the backend chosen more tabs with per-backend configuration are added. If this proves to be not possible for some reason we can add a new button next to the backend combo opening a dialog with the backend settings.
Comment 3 Roland Grunberg CLA 2012-07-04 14:55:29 EDT
Created attachment 218291 [details]
Launch Configuration Tab Group

I've implemented the following for the launch configuration tab group. Due to the Eclipse API not supporting adding/removing directly to the top-level tabs, I've added the tool-specific tabs under the tab that represents the profiling type. The launch configuration is being used to save and load all the options.

Currently there's some UI issues that need to be worked out (tabs don't show properly unless the window gets resized, scrolling doesn't work in the tabs) but this seems like the right approach.
Comment 4 Roland Grunberg CLA 2012-07-24 09:42:57 EDT
03928e0c779f06d1eb8975e559b4a8b7bfe4bdce, and acfd3a49fa186e514a5b9e2ecbca80a91c37ab55 have fixed the major issues mentioned.
Comment 5 Roland Grunberg CLA 2013-04-24 16:49:23 EDT
I think we can mark this as closed (fixed), with the unification framework having been completed/tested.