Bugzilla – Full Text Bug Listing
| Summary: | Typo in "Key 'mathProcessorName' is not found localization properties file" | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Markus Keller <markus.kell.r> |
| Component: | UI | Assignee: | Curtis Windatt <curtis.windatt.public> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | P3 | CC: | curtis.windatt.public |
| Version: | 3.8 | ||
| Target Milestone: | 4.3 M1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
We should only specify the file location if the localization header is set. If so, this can be accessed in BundleErrorReporter using helper.getNLFileBasePath(). The returned string does not include the .properties at the end. > We should only specify the file location if the localization header is set.
It would also be helpful in case Bundle-Localization is not set.
Note everyone knows that the default is /OSGI-INF/l10n/bundle.properties
(In reply to comment #2) > It would also be helpful in case Bundle-Localization is not set. > Note everyone knows that the default is /OSGI-INF/l10n/bundle.properties This can be done using org.eclipse.pde.internal.core.PDEManager.getBundleLocalization(IPluginModelBase). We don't want to confuse the user with a message about how a key is missing from a file that doesn't exist. Two different messages based on whether the file exists would work. Fixed in master http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=774033f8a4beb1aad1bfe829b266b000285a6690 After experimenting with it, a single message is satisfactory and not confusing. If the localization property is set, the message says that the key is missing from it. Otherwise, the message uses the default location. Verified I20120808-2000 |
org.eclipse.equinox.bidi has an extension that declares <typeDescription class="org.eclipse.equinox.bidi.internal.consumable.STextMath" description="%mathProcessorName" type="math"> </typeDescription> ... but the %mathProcessorName is missing. Error message: Key 'mathProcessorName' is not found localization properties file Correct error message: Key 'mathProcessorName' is not found in localization properties file It also wouldn't hurt if the path to the localization properties file was appended to the error message.