Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 382770

Summary: Eclipse.org nova theme doesn't pass the W3C Markup Validation Service
Product: Community Reporter: Christopher Guindon <chris.guindon>
Component: WebsiteAssignee: phoenix.ui <phoenix.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: david_williams, nathan
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Fix w3c validation errors none

Description Christopher Guindon CLA 2012-06-15 15:49:40 EDT 
Build Identifier: 

For example if we try to validate this page http://www.eclipse.org/membership/
we get 7 errors and 1 warning.

The 7 errors can easily be fix by replacing the <div> element with <span>.
We might need to update the css here.

The final warning is with the google search.

Line 57, Column 132: reference not terminated by REFC delimiter
…/brand?form=searchbox_017941334893793413703%3Asqfrdtd112s&lang=en"></script>	

I would need to test but replacing the &lang= with &amp;lang= should remove the error.

I will create a patch early next week for this.



Reproducible: Always
Comment 1 Christopher Guindon CLA 2012-06-18 11:14:39 EDT 
Created attachment 217500 [details]
Fix w3c validation errors

After applying this patch the membership page will validate. 

Changes:

-Visit other eclipse site : Pop-up text is wrapped around a span instead of a div
-update css rules to check for span
-google search is now using &amp; instead of only &
Comment 2 Nathan Gervais CLA 2012-06-18 11:46:45 EDT 
Applied this patch locally and all seems good 

+1
Comment 3 Denis Roy CLA 2012-06-21 14:51:25 EDT 
+1
Comment 4 Christopher Guindon CLA 2013-03-15 13:00:43 EDT 
Better late than never! This patch was committed today :) 

http://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/commit/?id=3d2df796274f98f870797facae98d7e67ac8b733


The membership page was successfully checked as XHTML + RDFa:
http://validator.w3.org/check?uri=http%3A%2F%2Fwww.eclipse.org%2Fmembership%2F