Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 382539

Summary:	navigator needs build id in the footer
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne
Version:	0.5	Flags:	john.arthorne: review+
Target Milestone:	0.5 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-06-13 14:53:12 EDT

as part of our "early rendering" experiment (bug 334907 comment 11) I copied the header and footer to navigate.html.  

After it was copied, the build id was added to the footer.  We need the build id in the navigator footer.

Comment 1 Susan McCourt

2012-06-14 00:08:24 EDT

John, can you review?
commit is cb4928babc8aa1d97873f73e67d07ad0b71aca56
in remote branch bug382539.

The build id variable is actually in an externalized string.  The safest thing to do was to remove the copied footer HTML so that the dynamically inserted footer that is used on the other pages is inserted rather than having a copy of it.  Some day we might generate common header and footer into the HTML during the build, but until then, we should minimize the copied code and keep only the copied header since the goal is to get immediate feedback up top.

Comment 2 John Arthorne

2012-06-14 09:56:14 EDT

Looks good.

Comment 3 Susan McCourt

2012-06-14 11:19:57 EDT

pushed.