Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 382538

Summary:	deleting a folder from the root causes favorites to disappear.
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ken_walker, libingw
Version:	0.5	Flags:	libingw: review+
Target Milestone:	0.5 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-06-13 14:48:40 EDT

orion.eclipse.org
from the workspace root
delete a folder
the favorites disappear

the dom elements are still in the document but the DOM inspector shows me that the table full of content is only 4 px high.

Comment 1 Susan McCourt

2012-06-13 14:54:11 EDT

investigate...

Comment 2 Susan McCourt

2012-06-14 14:33:32 EDT

I have a fix for review in origin/bug382538.
Commit id is cf66b01d6c397f341805fdb42e93c96882deaa85

This is a one-line change.  The bug is fairly serious in that any explorer that calls "refresh" on a treetable widget could potentially delete all the tree table row dom nodes on the page, not just the ones in the widget.  Reoading causes everything to be regenerated, so it fixes itself.

Libing, you will recognize the fix as similar to the other selection query problems we found early on when pages first started to have more than one explorer.  The fix is to query the rows for the current parent widget, not the entire document.  

Given how serious the bug is, I am surprised we only see it in this case.  I tried to cause it to happen in git status, where there are multiple explorers/treetables on a page, but it seems as if most changedItem/refresh calls on those pages rerender everything rather than try to optimize the painting.  Similarly, "Favorites" and "Places" do re-rendering rather than optimized painting.  This is why we only see the problem in the navigator.

If this were RC3, I'd say "leave it alone."  This bug has probably been around since M2 and we never noticed it.  

But it turns out this bug occurs on all navigator optimized paints (changed item) which happens for 
- delete
- copy/paste
- move/copy
etc...

Comment 3 libing wang

2012-06-14 14:56:24 EDT

Reviewed and verified.
Pushed into origin/master.

I think in 1.0 we should use the navigation dictionary which was already used selection model, instead of dojo.query.

Comment 4 libing wang

2012-06-14 15:09:12 EDT

I put a TODO item in bug 380687 comment 3 for 1.0.