Bugzilla – Full Text Bug Listing
| Summary: | Tooltip help appears too fast | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Ken Walker <ken_walker> | ||||
| Component: | Client | Assignee: | Ken Walker <ken_walker> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | simon_kaegi, susan | ||||
| Version: | 0.5 | Flags: | simon_kaegi:
review+
|
||||
| Target Milestone: | 0.5 RC3 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
I looked into this. Fortunately everything goes through CommandTooltip. So you just want to change the showDelay property. I thought it'd be a one liner, but we also have to make sure our polling timer triggers after the initial delay, hence two line change.
here's a patch based on a different branch, so the line numbers might be slightly different, but you'll get the gist. Tweak that first showDelay number to your heart's content. The second change should always be showDelay + 500.
diff --git a/bundles/org.eclipse.orion.client.core/web/orion/commands.js b/bundles/org.eclipse.orion.client.core/web/orion/commands.js
index 44b3659..a1f78e7 100644
--- a/bundles/org.eclipse.orion.client.core/web/orion/commands.js
+++ b/bundles/org.eclipse.orion.client.core/web/orion/commands.js
@@ -146,6 +146,7 @@
constructor : function() {
this.inherited(arguments);
this.options = arguments[0] || {};
+ this.showDelay = 1500;
},
_onUnHover: function(evt){
@@ -190,7 +191,7 @@
this.polling = false;
this.close();
}
- }), 1000);
+ }), this.showDelay + 500);
},
_stillInDocument: function(node) {
Playing around with it, the standard 1000 seems to work pretty well. 1500 seems a bit long. (In reply to comment #2) > Playing around with it, the standard 1000 seems to work pretty well. 1500 seems > a bit long. yeah, I put in a big number just so I could tell it was working. See http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=Bug382302 Or cherry pick da0a25111bfdcf9030455ba4c6226f2b4f2917b5 to see Simon said "release the code" Pushed to master |
Created attachment 217186 [details] options tooltip over user menu Typically with a tooltip or hover help, you pause the pointing device around the hotspot and wait a bit for the tooltip. If you have been using a product for a while, you shouldn't be provided immediately with a tooltip and I find that the timeout currently on Orion to be just that. Too fast. The most annoying one I find is going to my name to get to Settings. As soon as I get there it say "options" which pops up over my navigation to "settings". If the pause was more like the second my other OS tooltips seem to be it would likely not pop up at all.