Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 382137

Summary: Editor title no longer indicates dirty state
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, susan
Version: 0.5Flags: mamacdon: review+
Target Milestone: 0.5 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Mark Macdonald CLA 2012-06-08 14:04:02 EDT 
Build id: I20120608-1132

1. Create a new file
2. Open it, change some stuff

The page title should change to the resource name followed by a '*' to indicate that the editor is dirty, but it does not.
Comment 1 Ken Walker CLA 2012-06-08 14:08:17 EDT 
Just tried OrionHub and it's ok as a reference
Comment 2 Susan McCourt CLA 2012-06-08 14:25:43 EDT 
Good catch, Mark.
This is a regression introduced by bug 349531.
There, I moved dirty state management to API so that pages don't go grabbing dom nodes to update dirty state.  However I do not update the browser tab title in that API and should.
Comment 3 Susan McCourt CLA 2012-06-11 12:14:49 EDT 
I have a fix.  
Because of bug 382274 I can't push this commit to a new remote topic branch.  So I rather bogusly pushed it to an old branch.

Mark, if you fetch the remote, can you cherry pick this commit?
33ee545fba8d01258fa237bd85b3a014ed535bce

Please push if you agree with the fix.
Comment 4 Susan McCourt CLA 2012-06-11 14:34:40 EDT 
Mark pointed out a problem with the sites page (and compare page had the same problem too).  
1) clients need to setPageTarget before calling setDirtyIndicator so that there is a title to update.
2) globalCommands should check that there is a title before trying to manipulate it.

Made these changes.  retested the editor, compare page, and site editor page.

The commit is 5db0d8804eb4873ea141b77c3ae90d8189635fef
and there is a remote branch called origin/bug382137