Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 382068

Summary:	Git log -switch to remote/tracking related pages links are gone
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Git	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	ken_walker, malgorzata.tomczyk, simon_kaegi, Szymon.Brandys
Version:	0.5
Target Milestone:	0.5 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-06-07 18:03:07 EDT

I know this working when Szymon fixed bug 380605 and I worked on related page menu life cycle later that day.

But this morning, the related pages links for git remote are gone completely, and I can't switch to local.  Git log has related pages, but the link to switch to remote is gone from that menu.

Not sure if this is related to Gosia's new fix for bug 381679 or not.  I recall verifying that the related pages menu came back, but I don't recall if "switch to remote/local" had come back or not....

This is not an RC1 blocker but we definitely need to fix for 0.5 RC2.

Comment 1 Malgorzata Janczarska

2012-06-08 10:33:30 EDT

This is not a problem with bug 381679, the link does not appear even when I remove the string externalization from it. The problem here is that visibleWhen() function returns false. From a quick debug it looks like Szymon assumed that the "item" in the function will be the log json, but it's in fact the folder json (response for /file/..).

Comment 2 Susan McCourt

2012-06-08 10:39:52 EDT

(In reply to comment #1)
> This is not a problem with bug 381679, the link does not appear even when I
> remove the string externalization from it. The problem here is that
> visibleWhen() function returns false. From a quick debug it looks like Szymon
> assumed that the "item" in the function will be the log json, but it's in fact
> the folder json (response for /file/..).

perhaps this was me, then...I'll revisit my fix for bug 381869.  It's very possible that I tested this fix before related pages came back...

Comment 3 Susan McCourt

2012-06-08 10:42:00 EDT

yep, it was that fix.
I changed the page target for the breadcrumb and should have only changed the breadcrumb target.

Comment 4 Susan McCourt

2012-06-08 11:10:48 EDT

I have a (one line) fix for this ready, if there were to be another RC1 build I'd like to get it in...

Comment 5 Susan McCourt

2012-06-08 11:23:54 EDT

Talked to Simon.  Fix is localized to git log, so we are pushing it.
Fixed in
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=288096716bdf2e0c5225ed2af344b33aa26528a5