Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 382034

Summary:

compare widget jumps to top of page when I click "next change"

Product:

[ECD] Orion

Reporter:

Susan McCourt <susan>

Component:

Client

Assignee:

libing wang <libingw>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

libingw, Szymon.Brandys

Version:

0.5

Flags:

susan: review+

Target Milestone:

0.5 RC2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Susan McCourt

2012-06-07 13:48:43 EDT

working in git status 2.
I expanded a change.
The compare widget was in the middle of the page.
I clicked "next change".
The compare widget jumps to the top of the page.

Comment 1 Susan McCourt

2012-06-07 13:49:38 EDT

not only does this make me lose my context, but I can no longer see the twistie that expanded my change, so I have to scroll back up if I want to close it.

Comment 2 Susan McCourt

2012-06-07 14:13:05 EDT

I can't make this happen every time, need to work on some reproducible steps.  At the moment I wrote the bug (running git status 2 in HEAD), I was in state that this happened every time.  However it did not happen the next time I reloaded the page.

Comment 3 libing wang

2012-06-07 15:26:18 EDT

I know the trick.
In order to support up/down arrow keys navigation in selection model level, I'm checking if row is not fully visible I am using DIV.scrollToView.
This checking function is triggered on every selection/cursor change.
We need to fine tune this behavior in RC2.

Comment 4 libing wang

2012-06-07 15:29:04 EDT

It just so happened in status page as the widget is a big view. Has nothing to do with compare widget, nor does it with the section.

Comment 5 libing wang

2012-06-07 15:29:35 EDT

(In reply to comment #4)
> It just so happened in status page as the widget is a big view. Has nothing to
> do with compare widget, nor does it with the section.

big view --> big row.

Comment 6 libing wang

2012-06-13 10:48:54 EDT

Created attachment 217278 [details]
Patch

Susan, could you review the patch?

Comment 7 libing wang

2012-06-13 17:08:40 EDT

Susan, could you review the fix on origin/bug382540&382034 ?
I am using one commit for both  bug 382540 and bug 382034 because they are in the same selection model area.

Comment 8 Susan McCourt

2012-06-14 13:42:54 EDT

+1.  This makes a big difference in keeping context while reviewing changes.
Pushed to master.

Comment 9 libing wang

2012-06-14 14:12:58 EDT

Thanks for the review, Susan.