Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 381739

Summary:	[client] 'Related' does not work when switched to Remote on git log
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Git	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.5
Target Milestone:	0.5 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	380605

Description Szymon Brandys

2012-06-05 12:14:09 EDT

Steps:
1) Go to log page for active branch
2) Click 'Related', you should see some related pages there
3) Click 'Switch to Remote' on actions bar
4) When the page reloads, click 'Related' again

It ends up with an error in console and nothing is shown. Refreshing the page fixes the problem.

Comment 1 Szymon Brandys

2012-06-05 12:16:52 EDT

The error is:
node is null
http://localhost:8080/org.dojotoolkit/dojo/_base/html.js
Line 1839
:(

Comment 2 Susan McCourt

2012-06-05 16:41:35 EDT

Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=cf80d7cbe18c59de97a6eafc83c99ab5a42d4cf4

There was an orphaned links menu on hash change (was happening in navigator, too).  Some of this code switched to asynch/deferred list with the localization changes, and I had to do some widget cleanup afterward, but did not catch this case.

I think git log is the first page where a related page hashes, so after this fix, the related menu hangs open and you can see it fill in with the new items.  I added some code to close the menu when the menu is emptied.  There is still a slight pause between clicking the link and the menu going away, but I think this is good for now.