Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 38171

Summary: PageLayout contains non NLS-ed strings
Product: [Eclipse Project] Platform Reporter: Debbie Wilson <debbie_wilson>
Component: UIAssignee: Tod Creasey <Tod_Creasey>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: n.a.edgar
Version: 2.1Keywords: nl
Target Milestone: 2.1.1   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
Proposed fix none

Description Debbie Wilson CLA 2003-05-27 15:52:48 EDT 
The class PageLayout contains 2 non-NLSed strings:
"Referenced part does not exist yet: " and
"Part already exists in page layout: "

These areas should be using WorkbenchMessage.getString() or 
WorkbenchMessage.getFormat() depending on whether or not arguments are 
involved.

There is also a comment for a NON_NLS-ed string which shouldn't be there 
(search for NLS).
Comment 1 Debbie Wilson CLA 2003-05-27 16:23:24 EDT 
Created attachment 4981 [details]
Proposed fix

This is a patch for
project - org.eclipse.ui.workbench
package - org.eclipse.ui.internal

Nick, could you review and/or pass to someone else to review.
Comment 2 Nick Edgar CLA 2003-05-28 15:28:15 EDT 
Tod, could you please verify Deb's changes?
Comment 3 Tod Creasey CLA 2003-05-28 15:49:26 EDT 
Verified fixes against HEAD.
Comment 4 Tod Creasey CLA 2003-05-29 08:54:48 EDT 
Did you want me to release these?
Comment 5 Debbie Wilson CLA 2003-05-29 09:30:49 EDT 
Yes, please.  I don't believe I have commit rights yet.
Comment 6 Tod Creasey CLA 2003-05-29 09:35:53 EDT 
Released for build >20030529
Comment 7 Tod Creasey CLA 2003-05-30 15:07:14 EDT 
Should consider for 2.1.1. Reopening pending consideration by Nick.
Comment 8 Tod Creasey CLA 2003-06-02 14:51:11 EDT 
Released to 2.1.1 stream
Comment 9 Tod Creasey CLA 2005-05-10 14:54:15 EDT 
Marking as closed.