Bugzilla – Full Text Bug Listing
| Summary: | Plug-ins localization confusion | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Szymon Brandys <Szymon.Brandys> |
| Component: | Client | Assignee: | Malgorzata Janczarska <malgorzata.tomczyk> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | simon_kaegi, susan |
| Version: | 0.5 | ||
| Target Milestone: | 0.5 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
> Either the property should be nameKey/tooltipKey or we should have
> name: message["Git Status"] as in other places.
We can't have message["Git Status"], because that would require to localize messages on the plugin site and we are moving it to the client. nameKey/tooltipKey should be fine though.
Done. This page describes how to globalize plugins now: http://wiki.eclipse.org/Orion/Internationalization#Plugins I had to revert the fix since 'Related' pages stopped working. Reverting commit is 94fd854b815c2ba9e7e9e6f53ec9ae92b90d36cf. (In reply to comment #3) > I had to revert the fix since 'Related' pages stopped working. Reverting commit > is 94fd854b815c2ba9e7e9e6f53ec9ae92b90d36cf. Sorry about that, corrected. |
See gitplugin.html for instance: provider.registerServiceProvider("orion.navigate.command", {}, { name: "Git Status", id: "eclipse.git.status", tooltip: "Go to Git Status", nls: "git/nls/gitmessages", validationProperties: [ {source: "Git:StatusLocation", variableName: "GitStatusLocation"}, {source: "Directory", match: true} ], uriTemplate: "{OrionHome}/git/git-status2.html#{GitStatusLocation}", forceSingleItem: true }); With the recent change in localization "Git Status" and "Go to Git Status" are no more messages, but keys in the message file pointed in nls property. That's confusing. Either the property should be nameKey/tooltipKey or we should have name: message["Git Status"] as in other places.