Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 381262

Summary:	Navigation on iPad - highlighting issues
Product:	[ECD] Orion	Reporter:	Anton McConville <antonm>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	susan
Version:	unspecified
Target Milestone:	0.5 RC1
Hardware:	Other
OS:	iOS
Whiteboard:

Description Anton McConville

2012-05-31 15:46:34 EDT

I notice when I expand the navigation tree on the iPad, that multiple rows are highlighted. Not sure if this is intentional, but I find it confusing that so many rows are highlighted. I would expect just the row that I last opened or selected to be highlighted.

Comment 1 Susan McCourt

2012-05-31 15:52:21 EDT

The ipad does have a different selection mode than the desktop.  It uses a toggle select mode (click to add row to selections, click again to deselect) rather than extended select (where click is a single select and ctrl-click is a multiselect).  Lots of discussion on this difference in bug 377018 comment 19 and many surrounding comments.

However it is not correct that expanding a parent in the navigator should select all children.  That should only be happening in the search replace page, which is a special case of "container select."

Libing?

Comment 2 libing wang

2012-06-01 08:52:28 EDT

I think what Anton complained is that when you click on the twistie the click event got bubbled up to the row DIV.
I can check if the event target equals to the row DIV or not.
I am currently checking:
If the click event comes from any grid then ignore the row click that was bubbled up.
After I removed the grid on twistie, it accidentally select the row. We should not allow this to happen on both desktop and ipad.

Comment 3 libing wang

2012-06-01 09:30:36 EDT

(In reply to comment #2)
> I can check if the event target equals to the row DIV or not.
Click event on the row comes from all the cells. So I cant rely on checking that.
But I can check if the event comes from the twistie or not. If yes I just ignore the row level click that was bubbled up.

Fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bf474ed707dc952752da81312f5108239bbfeb7f.

Comment 4 libing wang

2012-06-01 09:39:56 EDT

Verified with my iPAd3.
So now on both desktop and ipad, clicking on twist no longer selects a row.