Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 381260

Summary: why is editor is making multiple requests for metadata?
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: 0.5   
Target Milestone: 0.5 RC1   
Hardware: PC   
OS: Windows 7   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=427194
Whiteboard:

Description Susan McCourt CLA 2012-05-31 15:31:40 EDT
Simon observed 5-6 requests for metadata on the editor page.  He thinks is more recently.  Why?
Comment 1 Mark Macdonald CLA 2012-05-31 15:54:17 EDT
I haven't seen 5-6, but I am consistently getting 4 requests for data when I reload the editor:

1.) 1 request for file contents
>    /file/X/Y/foo.js

2.) 1 request for file metadata
>    /file/X/Y/foo.js?parts=meta

3.) 1 request for parent folder metadata
>    /file/X/Y/?parts=meta

4.) A duplicate of #3
>   /file/X/Y/?parts=meta

#4 is totally superfluous. Not sure about #3 (what is it for?).
Comment 2 Susan McCourt CLA 2012-05-31 16:12:01 EDT
I observe 5 requests for metadata on orionhub (M2).
The file metadata, and then four requests for the parent folder metadata.

On the current build, it is 6 requests (one for file, 5 for folder).

The problem is that the related links code is fetching the folder for each related link that doesn't validate against the file.  Instead we need a deferred that they all wait on so that it's only fetched once.

I have a fix but can't push it due to bug 381266
Comment 3 Susan McCourt CLA 2012-05-31 16:13:44 EDT
(In reply to comment #1)
 
> #4 is totally superfluous. Not sure about #3 (what is it for?).

some of the related links on the editor page are valid for a folder but not a file.  The editor supplies an "alternate item" for related links.  This is what lets commands like "git status" work for the editor.  The alternate item is fetched when a related link is found that doesn't validate on the original metadata (but we shouldn't be fetching it over and over).