Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 381092

Summary:

ESC keybinding firing twice

Product:

[RT] RAP

Reporter:

Jesus Luna Quiroga <jrlq>

Component:

Workbench

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jrlq

Version:

unspecified

Target Milestone:

2.0 M1

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Configuration file for register ESC key sequence	none
Proposed patch	none

Description Jesus Luna Quiroga

2012-05-30 14:35:27 EDT

Build Identifier: 1.5 RC1

Using the org.eclipse.ui.bindings extension point the ESC key sequence fires twice an action bound to it, no other key sequence behaves like that, this is reproduced across all common browsers (Chrome, FireFox 12, IE9).

The problem is not reproduce at RWT/SWT level (KeyListener or Display filters) the event is registered or triggered fine.

Reproducible: Always

Comment 1 Jesus Luna Quiroga

2012-05-30 14:37:34 EDT

Created attachment 216509 [details]
Configuration file for register ESC key sequence

Configuration file for register ESC key sequence

Comment 2 Ivan Furnadjiev

2012-06-25 04:12:59 EDT

Created attachment 217800 [details]
Proposed patch

This patch removes the display filter for SWT.Traverse in BindingService. As out-of-order key processing is not available in RAP (see WorkbenchKeyboard#isOutOfOrderKey), listening for traverse events is useless.

Comment 3 Ivan Furnadjiev

2012-08-01 08:28:12 EDT

Applied patch to Git master with commit 66b81be886ca7dcc32f5a654ee27bc0e1208237e.