Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 381042

Summary:	[Globalization] Messages are loaded even if their language is not used
Product:	[ECD] Orion	Reporter:	Malgorzata Janczarska <malgorzata.tomczyk>
Component:	Client	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	simon_kaegi
Version:	0.5	Flags:	simon_kaegi: review+
Target Milestone:	0.5 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Malgorzata Janczarska

2012-05-30 09:30:55 EDT

Messages in all installed languages are loaded regardless for current locale. If I have Japanese plugins installed, but I'm using Polish locale, messages in Japanese will still be downloaded.

Comment 1 Malgorzata Janczarska

2012-06-13 07:48:43 EDT

Commit to review:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=Bug381042

Comment 2 Simon Kaegi

2012-06-13 10:56:58 EDT

That doesn't sound right - please wait. The Japanese i18n module should not be getting loaded at all by the requireJS i18n plugin. The bug is higher up the stack if it's getting loaded.

Comment 3 Simon Kaegi

2012-06-13 14:26:15 EDT

Great bug. Fixed.
This is a problem that is fixed in RequireJS 2.0 where only a module that is required will get defined. I tweaked Gosia's patch to not define the module instead of defining an empty module and Gosia re-tested.