Bugzilla – Full Text Bug Listing
| Summary: | Server Icon is Eclipse 4.2 | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Ian Skerrett <ian.skerrett> |
| Component: | Releng | Assignee: | Anthony Hunter <ahunter.eclipse> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | ahunter.eclipse, gheorghe, ken_walker, mike.milinkovich, torkildr |
| Version: | 0.5 | ||
| Target Milestone: | 6.0 M2 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
| Bug Depends on: | 379297 | ||
| Bug Blocks: | |||
|
Description
Ian Skerrett
We actually have a good icon, but there was a bug in the p2 branding code that prevents it working for a large 256x256 icon. We will need to move up to a new builder with this fix. Did we get a new builder for this? No we are still using the eclipse 3.7 builder. At this point we'll just move up after we both ship. I upgraded to 3.8 base builder and unfortunately the branding still did not apply. http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=fffb35d93527321d6382ece348bdc800fbec29d9 I have checked the orion.ico file and the icons look good. I tried manually invoking the branding iron and it applied the orion icons correctly to the executable, so I need to debug the build to figure out what is going on. It is possibly a problem of the orion.ico not being found at build time. Found this in the build log: generate.p2.metadata: [eclipse.brand.p2.artifacts] Error - 7 icon(s) not replaced in /opt/public/eclipse/e4/orion/I201211222230/tmp/p2.branding/org.eclipse.equino x.executable_root.win32.win32.x86/launcher.exe using /shared/eclipse/e4/orion/I201211222230/../support/org.eclipse.orion.releng/builder/html /orion.ico This message comes from IconExe line 79. It means the executable was found and contained 7 images, but there were no matching replacement images found. I confirmed the orion.ico referenced in that path above was present and correct though. Again, running IconExe on my Windows box with the same inputs ran correctly with no errors. Bogdan and I are both stumped at the moment. Any chance this is going to get fixed for Orion 2.0 ? (In reply to comment #6) > Any chance this is going to get fixed for Orion 2.0 ? Nope. I'm seeing this same thing when building our Eclipse 4.4 based product using PDE build. The builder we're using is from Eclipse 4.4M7. (In reply to Torkild U. Resheim from comment #8) > I'm seeing this same thing when building our Eclipse 4.4 based product using > PDE build. The builder we're using is from Eclipse 4.4M7. Torkild, This bug is related to the fact that the Orion server process uses the Eclipse icon. If your bug is that you are picking up an old Eclipse icon for your project's build, you should file a separate bug. John, While I have you, any chance of fixing this in 6.0? Mike, Sorry for hijacking the bug. I realize it appears to be specific to Orion. However I see exactly the same symptoms. The log output is the same and the icons in the *.exe file are not replaced. They remain those of Eclipse (4.4 in this case). I also tested by building IconExe and running it on my .exe and *.ico which produced a correct result. This has been fixed. I have 6.0 M2 Windows build and I see the iron logo in the exe file. |