Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 380819

Summary: Search and replace puts original on right and proposed change on left
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: libingw
Version: 0.5   
Target Milestone: 0.5 RC1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description John Arthorne CLA 2012-05-28 11:18:02 EDT
0.5 M1

When you perform search and replace, it shows the current file on the right hand side, and the proposed changes on the left hand side. This feels backwards to me, somehow I would expect the current file on the left and the proposed changes on the right. Maybe it's because I think of the mathematical notation of an operation like A -> B. Also note Eclipse does the reverse of Orion - original on left and proposed change on right.
Comment 1 libing wang CLA 2012-05-28 13:54:21 EDT
I might have been wrong at very beginning.
I thought about it from a compare point of view: the older file is always on the right side and the newer on the left side(e.g. working tree VS master, newer commit VS older commit).
In replace page when compare widget is initiated, I am passing proposed contents as the newer and the original contents as older file.
So I think the easiest trick we can play is to reverse the order. And because it is a read only widget, it does not really matter as long as left side is not editable.