Bugzilla – Full Text Bug Listing
| Summary: | Hiding and showing Gitstatus2 unstaged section looks wrong | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Ken Walker <ken_walker> | ||||
| Component: | Client | Assignee: | libing wang <libingw> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | libingw, Silenio_Quarti, susan, Szymon.Brandys | ||||
| Version: | 0.4 | Flags: | Silenio_Quarti:
review+
|
||||
| Target Milestone: | 0.5 RC2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Libing, is there anything we can do with compare widget to have good animation? (In reply to comment #1) > Libing, is there anything we can do with compare widget to have good animation? I am putting this to RC1. I believe resizing the widget height in the timer should fix it. Something like : dojo.style(comapreWidgetParentDiv. "height" , decreasingHeight) in a timer. I need to figure out a way hwo to cut this into section.js at changeExpandedState function . Maybe we need a customized onAnimate function and pass it into section. In bug 380830, Susan added an onExpandCollapse callback to sections. I will see if this function can help on setting compare widget to a zero height DIV. This will be the very last one before I fix other RC2s. If there is no qucik solution we need to re-think about the way that a section animates. Seems that if we really want to fix it for RC2 we may want to listen to "onPlay" event from the dojo toggler. Then we may want to be able to set the section contentent DIV's height that holds the whole thing(explorer). I am not sure yet... Talked to Ken. It is a nice to fix if th solution is safe and simple. Otherwise we should fix this in 1.0. +1 for the changes I saw on Libing's machine. Thanks Silenio for the review and suggestions. Pushed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=611e83b9571ed6de51f08c5e628a8e94d6de6fc4. |
Created attachment 216138 [details] Video of Unstaged expand/collapse Adding a video attachment of expanding and collapsing the unstaged section. I think the animation is good but maybe the ordering of making the text widget appear and disappear is wrong?