| Summary: | Gitstatus compare widget says "word added" when it should be "line added" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Ken Walker <ken_walker> | ||||
| Component: | Client | Assignee: | libing wang <libingw> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | minor | ||||||
| Priority: | P3 | ||||||
| Version: | 0.4 | ||||||
| Target Milestone: | 3.0 RC2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
This was already fixed. But we only show tool tips for WORD level diff annotations now. For the LINE/BLOCK level diff annotations, it is too noisy to show "line added". The whole block of lighter color of green/red is good enough to show they are line diffs or block diffs. We only show a little darker color if there is a WORD level diff inside a LINE/BLOCK. In that case you need a tool tips like "word added" or "word deleted". This bug happened before because we were literally generating a big WORD diff which is identical to the line diff, where the the big WORD diff has the priority to show its tool tips. But now the big WORD diff is gone in this case. |
Created attachment 216129 [details] Example of word added instead of line added Attaching an image of an added line and when I hovered over the change it said "word added" but that wasn't true, it was a whole line added.