Bugzilla – Full Text Bug Listing
| Summary: | CBI pull request for Platform for non-pom file changes | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thanh Ha <thanh.ha> |
| Component: | Releng | Assignee: | Platform-Releng-Inbox <platform-releng-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | andrea.ross, daniel_megert, david_williams, igor, john.arthorne, pwebster, thanh.ha |
| Version: | 4.2 | ||
| Target Milestone: | 4.2.1 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 379747 | ||
|
Description
Thanh Ha
R3 eclipse.platform.releng: 1e97f587288c5a9bf4a51dc5c0e4c9e249137ac2 http://git.eclipse.org/c/cbi/eclipse.platform.releng.git/commit/?h=R3_cbinopoms&id=1e97f587288c5a9bf4a51dc5c0e4c9e249137ac2 daa3e46c24fb3b7a80bbfa93c346c8a74e921c9d http://git.eclipse.org/c/cbi/eclipse.platform.releng.git/commit/?h=R3_cbinopoms&id=daa3e46c24fb3b7a80bbfa93c346c8a74e921c9d R4 eclipse.platform.releng: 9a5a4497fdec44806809fbc099248164f7fe419a http://git.eclipse.org/c/cbi/eclipse.platform.releng.git/commit/?h=R4_cbinopoms&id=9a5a4497fdec44806809fbc099248164f7fe419a 6d1408d8d3a1ad6bfef7e3698691d5bfc382951b http://git.eclipse.org/c/cbi/eclipse.platform.releng.git/commit/?h=R4_cbinopoms&id=6d1408d8d3a1ad6bfef7e3698691d5bfc382951b Can you please explain each of those changes, like e.g. adding Import-Package: org.apache.xerces.parsers;version="0.0.0" to /org.eclipse.update.examples/META-INF/MANIFEST.MF. At this point (RC2), we should try to avoid such changes. (In reply to comment #2) > Can you please explain each of those changes, like e.g. adding > Import-Package: org.apache.xerces.parsers;version="0.0.0" > to /org.eclipse.update.examples/META-INF/MANIFEST.MF. > > At this point (RC2), we should try to avoid such changes. Igor made most of the modifications so I hope he can explain each one. The one change I did make was adding build.properties to org.eclipse.license. R3 eclipse.platform.releng: daa3e46c24fb3b7a80bbfa93c346c8a74e921c9d http://git.eclipse.org/c/cbi/eclipse.platform.releng.git/commit/?h=R3_cbinopoms&id=daa3e46c24fb3b7a80bbfa93c346c8a74e921c9d R4 eclipse.platform.releng: 6d1408d8d3a1ad6bfef7e3698691d5bfc382951b http://git.eclipse.org/c/cbi/eclipse.platform.releng.git/commit/?h=R4_cbinopoms&id=6d1408d8d3a1ad6bfef7e3698691d5bfc382951b This change was necessary for Tycho to find what license files to be included in features that reference the license feature. There was discussion on this in the cbi-dev mailing list. Link below. http://dev.eclipse.org/mhonarc/lists/cbi-dev/msg00234.html We discussed this in the PMC decided that no changes except pom.xml addition should made for Juno at this point. (In reply to comment #2) > Can you please explain each of those changes, like e.g. adding > Import-Package: org.apache.xerces.parsers;version="0.0.0" > to /org.eclipse.update.examples/META-INF/MANIFEST.MF. > > At this point (RC2), we should try to avoid such changes. BuildZipPluginParser [1] uses classes from xerces. As far as I know xerces is not part of any standard bundle runtime execution environment and the only way to compile and run this bundle is to have explicit import on xerces. Let me know if you still have questions or concerns about this change. [1] http://git.eclipse.org/c/cbi/eclipse.platform.git/tree/update/org.eclipse.update.examples/src/org/eclipse/update/examples/buildzip/BuildZipPluginParser.java (In reply to comment #5) > (In reply to comment #2) > > Can you please explain each of those changes, like e.g. adding > > Import-Package: org.apache.xerces.parsers;version="0.0.0" > > to /org.eclipse.update.examples/META-INF/MANIFEST.MF. > > > > At this point (RC2), we should try to avoid such changes. > > BuildZipPluginParser [1] uses classes from xerces. As far as I know xerces > is not part of any standard bundle runtime execution environment and the > only way to compile and run this bundle is to have explicit import on > xerces. Let me know if you still have questions or concerns about this > change. > > > [1] > http://git.eclipse.org/c/cbi/eclipse.platform.git/tree/update/org.eclipse. > update.examples/src/org/eclipse/update/examples/buildzip/ > BuildZipPluginParser.java We don't build org.eclipse.update.examples any more. Certainly not for Juno (4.2). And even if we did, we're not going to add xerces as a prereq! :) (Just because we spent years getting rid of it). Plus, at least IBM's 1.4 JRE did have org.apache.xerces.* packages in it, and I think some of the sun JREs did too, but don't have them handy. So, given that, can you clarify what you need or what you are seeing? Are all the other commits in this bug still accurate/current? (That is, should I look at them one by one, or can you net it out for me?) Thanks!
>
> Plus, at least IBM's 1.4 JRE did have org.apache.xerces.* packages in it,
> and I think some of the sun JREs did too, but don't have them handy.
>
I looked in a few old Sun JRE's and couldn't find
org.apache.xerces.parsers.SAXParser
just renamed versions such as
com.sun.org.apache.xerces.parsers.SAXParser
So, not sure how we ever compiled this "example" ... but, hopefully won't have to figure it out since not needed any longer?
Let me know how I can help make progress on that issue (if it is still an issue).
org.eclipse.update.examples should not be built and has already been deleted from master. What branches do we need to remove it from to make CBI work? (In reply to comment #8) > org.eclipse.update.examples should not be built and has already been deleted > from master. What branches do we need to remove it from to make CBI work? Is this change going to be part of SR1? If so when we rebase the CBI platform build to SR1 it should pull in this change too and from the CBI side we just need to remove the pom file from the build. (In reply to comment #9) > (In reply to comment #8) > > org.eclipse.update.examples should not be built and has already been deleted > > from master. What branches do we need to remove it from to make CBI work? > > Is this change going to be part of SR1? Update.examples was removed before Juno SR1 in this commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?h=pwebster/R4_2_maintenance&id=9ea218ef9e86d5f00fe7d5bfc92c26b46b6c347f > If so when we rebase the CBI platform build to SR1 it should pull in this > change too and from the CBI side we just need to remove the pom file from > the build. I am going to mark this resolved then. |