Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 380007

Summary: GEF's flyout palette displays unused space in gray rather than white
Product: [Tools] GEF Reporter: Shenxue Zhou <shenxue.zhou>
Component: GEF-Legacy GEF (MVC)Assignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hudsonr, konstantin, nyssen
Version: unspecified   
Target Milestone: 3.8.1 (Juno SR1)   
Hardware: All   
OS: All   
Whiteboard:

Description Shenxue Zhou CLA 2012-05-18 13:47:45 EDT 
If I collapse my connections and objects group in my flyout palette, the bottom of the palette is painted gray rather than white. It looks a little odd.
Comment 1 Konstantin Komissarchik CLA 2012-05-18 13:57:27 EDT 
This looks particularly bad on Eclipse 4.x where the editor has a white margin around its composite.
Comment 2 Alexander Nyßen CLA 2012-05-21 04:21:41 EDT 
Agreed, that doesn't look nice and we should target for 4.2 in the future. However, we are past RC1 already, so this will not make it into the 3.8.0 release and will be a candidate for SR1 instead. 

The reason for the grey background is that SliderPaletteEditPart does not specify figure.setBackgroundColor(PaletteColorUtil.WIDGET_LIST_BACKGROUND) within its createFigure() method, but figure.setBackgroundColor(ColorConstants.button). You can thus work around this in the mean time by replacing the PaletteEditPartFactory of your graphical viewer with a modified version that returns a modified SliderPaletteEditPart, which overwrites createFigure() method accordingly.
Comment 3 Randy Hudson CLA 2012-05-21 09:51:12 EDT 
If the background color is not set explicitly on any figure, it inherits the background color from the control.  So you should try changing the background color of the control first before creating factories and overriding methods.
Comment 4 Alexander Nyßen CLA 2012-05-21 09:54:09 EDT 
(In reply to comment #3)
> If the background color is not set explicitly on any figure, it inherits the
> background color from the control.  So you should try changing the background
> color of the control first before creating factories and overriding methods.

Correct, but as SliderPaletteEditPart currently specifies a background color explicitly, a workaround will have to tweak this, as I have outlined above.
Comment 5 Alexander Nyßen CLA 2012-07-16 16:42:09 EDT 
Changed background color to list background. Pushed changes to master and R3_8_maintenace. Resolving as fixed.