Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 380004

Summary:

some selection/expansion issues with git-status2

Product:

[ECD] Orion

Reporter:

Susan McCourt <susan>

Component:

Git

Assignee:

Szymon Brandys <Szymon.Brandys>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

libingw, Mike_Wilson, Szymon.Brandys

Version:

0.5

Target Milestone:

0.5 M2

Hardware:

OS:

Windows 7

Whiteboard:

Bug Depends on:

Bug Blocks:

380421

Attachments:

Description	Flags
A selected comapre widget.	none

Description Susan McCourt

2012-05-18 13:19:21 EDT

I just used git-status2 to do an actual commit!
Overall, I really like the look of the page and the increased room for looking at the code.

As I worked with the page, though, there were some oddities that we need to think through with respect to the selection model, presentation of diff commands, etc.  Much of it has to do with the nature of us putting a compare widget inside an explorer, etc....

- The diff commands such as next/prev appear inline next to the diff in the row above the compare widget.  This is a nice, compact presentation.  But several times I pushed the down arrow icon(next diff) thinking I was moving a diff from unstaged to staged.  I was used to the stage down arrow appearing there.  This is muscle memory from the old page, but I think it could be a common mistake anyway.  Maybe we should be creating a dedicated command span for the compare widget that is separate from the row above?  

- When I select a diff, it turns gray (as expected in selection model.)  But after awhile, if I have selected and expanded diffs, those diffs start to look like "sections."  So I started thinking I could expand/collapse them by clicking anywhere on the row, but only the twistie does expand collapse.

Comment 1 Susan McCourt

2012-05-23 13:54:22 EDT

per a discussion we had today about various selection issues:

- we want to move the compare widget actions to their own line above the compare widget to reduce confusion about what the action applies to.
- we want to introduce stage and unstage as "default actions" in those lists.  These will appear to the left of the git status model icons and file name.

The confusion with section header vs. selection look is no longer an issue because the treatment for both of those things has changed to reduce confusion.  (We use a gold color for selection now instead of gray and we don't use gray section headers).

I'll assign this to Szymon for the specific issues mentioned above.

Comment 2 Susan McCourt

2012-05-23 14:50:06 EDT

(In reply to comment #1)
> per a discussion we had today about various selection issues:
> 
> - we want to move the compare widget actions to their own line above the
> compare widget to reduce confusion about what the action applies to.
> - we want to introduce stage and unstage as "default actions" in those lists. 
> These will appear to the left of the git status model icons and file name.
> 

here's a pic from the wiki
http://wiki.eclipse.org/Image:Orion-defaultaction.png

Comment 3 libing wang

2012-05-23 17:20:31 EDT

(In reply to comment #2)
> (In reply to comment #1)
> > per a discussion we had today about various selection issues:
> > 
> > - we want to move the compare widget actions to their own line above the
> > compare widget to reduce confusion about what the action applies to.
> > - we want to introduce stage and unstage as "default actions" in those lists. 
> > These will appear to the left of the git status model icons and file name.
> > 
> 
> here's a pic from the wiki
> http://wiki.eclipse.org/Image:Orion-defaultaction.png

I am holding off bug 380421 till this is fixed.
Talked to Susan about what "traverse to or select a widget row" means.
We agreed that making the compare action line and the widget together as one row makes sense in terms of row level selection. The renderer to generate this this row should know what should be put into grids.

Comment 4 libing wang

2012-05-23 17:23:40 EDT

Created attachment 216163 [details]
A selected comapre widget.

E.g. I think if the selected/traversed widget will look like this, bug 380421 then worth a fix.

Comment 5 Szymon Brandys

2012-05-24 13:14:14 EDT

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > per a discussion we had today about various selection issues:
> > >
> > > - we want to move the compare widget actions to their own line above the
> > > compare widget to reduce confusion about what the action applies to.
> > > - we want to introduce stage and unstage as "default actions" in those
> lists.
> > > These will appear to the left of the git status model icons and file name.
> > >
> >
> > here's a pic from the wiki
> > http://wiki.eclipse.org/Image:Orion-defaultaction.png
> 
> I am holding off bug 380421 till this is fixed.

Fixed.