Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 379811

Summary:	Compare widget actions in explorer
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Git	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw, susan
Version:	0.2
Target Milestone:	0.5 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	349328

Description Szymon Brandys

2012-05-17 10:11:41 EDT

Forked from Bug 379237, comment 10:

git-status2 use explorers to show staged and unstaged changes. Compare widgets render their actions in the parent actions div now. It works, but:
- commands are visible all the time, even if the compare widget is collapsed
- I use commandSpanId and set it to the parent actions div id. When I traverse the page using tab and enter the unstaged(staged) list and click tab again, the selection is changed to the first compare widget action instead of leaving the section. See the screenshot.
- actions are not right aligned

Comment 1 Susan McCourt

2012-05-17 11:25:41 EDT

I'll start with this as far as action alignment and helping with the hide/show actions goes.

The traversal issue is a slightly bigger issue.  Libing...what we need is that the compare widget can be passed the nav grid holder array so that when it renders commands, those commands get added to the traversal.  What I don't know is the timing/life cycle of all this. The commands get rendered long after the row that will contain them get rendered.  We'll probably need to talk about this.

Comment 2 Susan McCourt

2012-05-17 16:25:20 EDT

(In reply to comment #0)
> Forked from Bug 379237, comment 10:
> 
> git-status2 use explorers to show staged and unstaged changes. Compare widgets
> render their actions in the parent actions div now. It works, but:
> - commands are visible all the time, even if the compare widget is collapsed

now fixed.  I had to add an innerspan for the compare widget actions and hide/show this span when the expand state changes.  I couldn't simply hide/show the entire actions column because that affected the drawing of the line separator (shortened it when the actions column disappeared.)

> - I use commandSpanId and set it to the parent actions div id. When I traverse
> the page using tab and enter the unstaged(staged) list and click tab again, the
> selection is changed to the first compare widget action instead of leaving the
> section. See the screenshot.


> - actions are not right aligned
fixed.  The explorer should style the actions column to be right justified.

Comment 3 Susan McCourt

2012-05-18 14:56:43 EDT

Libing and I swapped some bugs this morning, he's going to look at the remaining traversal issue.

Comment 4 libing wang

2012-05-18 16:56:41 EDT

Fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=48cc193ae8245ebf634d1bc0ffe9df7aeaafa20e.

You can now use key board on all compare commands.