Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 379797

Summary: git-status2 has a problem when staging changes
Product: [ECD] Orion Reporter: Szymon Brandys <Szymon.Brandys>
Component: GitAssignee: libing wang <libingw>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 CC: libingw
Version: 0.2   
Target Milestone: 0.5 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
git-status2 after stage operation
none
More details none

Description Szymon Brandys CLA 2012-05-17 08:27:08 EDT 
Steps:
1) Go to git-status2 and have an unstaged change
2) Select the change and stage it using the action in the section header

Console says:
TypeError: node is null
http://localhost:8080/org.dojotoolkit/dojo/_base/html.js
Line 1803

and the page is not fully loaded. See the screenshot.
Comment 1 Szymon Brandys CLA 2012-05-17 08:28:30 EDT 
Created attachment 215764 [details]
git-status2 after stage operation

When I refresh the page, everything is loaded properly.
Comment 2 Szymon Brandys CLA 2012-05-17 08:32:40 EDT 
Created attachment 215765 [details]
More details

This is the stack when the problem happens. it seems like the tree tries to toggle some selection related class on non-existing node.
Comment 3 libing wang CLA 2012-05-17 08:37:37 EDT 
(In reply to comment #2)
> Created attachment 215765 [details]
> More details
> 
> This is the stack when the problem happens. it seems like the tree tries to
> toggle some selection related class on non-existing node.

Good catch, I think there must be a timing issue there when the selection model is built up. Will fix in M2.
Comment 4 Szymon Brandys CLA 2012-05-21 09:00:01 EDT 
I don't see the problem anymore. Libing, did you fix it or it was just fixed by accident?
Comment 5 libing wang CLA 2012-05-22 09:40:23 EDT 
(In reply to comment #4)
> I don't see the problem anymore. Libing, did you fix it or it was just fixed by
> accident?

fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=132bb463d28705703ab31aa44bd90717bc978b29.
Just forgot to close it.