Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 379685

Summary:	"Too much recursion" on search+replace site on FF
Product:	[ECD] Orion	Reporter:	Malgorzata Janczarska <malgorzata.tomczyk>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.5
Target Milestone:	0.5 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Malgorzata Janczarska

2012-05-16 09:06:57 EDT

This is easy reproduceable on FF, but can be reproduced also on Chrome

To reproduce:
1. Do a search
2. Click Replace
3. input something and click "Preview changes"
4. select files to see the compare on the bottom

after two selection changes you browser hangs. "Too much regression" error is shown in the logs.

Comment 1 libing wang

2012-05-16 09:33:53 EDT

Search and replace overwrites some default behavior from selection model.
Investigating now.

Comment 2 libing wang

2012-05-16 12:29:08 EDT

The check box and row are racing on selection model. Will fix it today.

Comment 3 libing wang

2012-05-16 18:28:17 EDT

I released the code so that you can change selection but the check box is not reflecting the micro change inside a file.
I am lowering sev to major.

Comment 4 Malgorzata Janczarska

2012-05-17 05:55:23 EDT

I made a typo, the error message shown is "Too much recursion" not "Too much regression".
The fix Libing made now solved the most severe problem, so I will lower the priority to "normal" now.

Comment 5 libing wang

2012-05-17 08:33:53 EDT

(In reply to comment #4)
> I made a typo, the error message shown is "Too much recursion" not "Too much
> regression".
> The fix Libing made now solved the most severe problem, so I will lower the
> priority to "normal" now.

Yeah, I realized that it would've been recursion when I saw the checkbox racing with row selection. Would be nice if FF can detect regressions :-).

The check box is not filtering out replacement properly due to the selection model implementation,  I I will fix that part and close the bug.

Comment 6 libing wang

2012-05-24 17:55:02 EDT

I do not see the filtering issue after several fixes on selection model.
I verified that you can filter on file level and line and word level to do the replace.