Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 379462

Summary:	orion/util is a dumping ground
Product:	[ECD] Orion	Reporter:	Simon Kaegi <simon_kaegi>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, libingw, mamacdon
Version:	0.5
Target Milestone:	1.0 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Simon Kaegi

2012-05-14 15:30:23 EDT

This module should not exist. "util" is too general a name and already there is a bunch of unrelated functionality living there. At the very least the bits and pieces should be moved out to more specific util modules.

Comment 1 Susan McCourt

2012-05-14 22:51:33 EDT

this is a good RCx kind of thing.
The original idea was stateless UI helpers that were independent of any particular module.  Since then, we've adopted requirejs, we have an idea of the module boundaries, and some stuff in here should just become an export of a particular related modules.  Stuff that's truly stateless UI helper stuff could be in a "UI utils" helper, etc.

Comment 2 Susan McCourt

2012-05-31 12:09:53 EDT

moving code cleanup bugs (that don't help performance) to 1.0

Comment 3 Susan McCourt

2012-08-14 13:50:22 EDT

There's been a lot of trimming of stuff out of here, will revisit during M2

Comment 4 Susan McCourt

2012-10-02 14:05:38 EDT

Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b896b7fe6a0601a8befd658b170134f786722848

1) Got rid of methods in util that were no longer used.
2) Where there was only one caller and it didn't seem generally useful, I moved the method to the caller.
3) Separated the remaining code into two modules:
  orion/fileUtils contains path manipulation stuff, etc.
  orion/uiUtils contains generic UI helpers (prompting, etc.)
4) Fixed up callers

The biggest job was getting rid of MANY (50+) references to "orion/util" that were not actually referenced anywhere in the code.  Probably just stuff copied and pasted around.  Hence I touched almost all the UI files.

cc'ing Libing, Anton, Mark just as a heads up.  I tried to open every page I changed and exercise it to make sure I hadn't broken anything...