Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 379429

Summary:	Favorites section missing if you don't have any favorites yet
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	bostone
Version:	0.4
Target Milestone:	0.5 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2012-05-14 10:37:59 EDT

I20120513-2230 on orion.eclipse.org.

- Go to Navigator page
- Remove all favorites

-> The entire favorites section disappears from the LHS. I don't know if this is intentional, but some thoughts:

- There is functionality in that section to add arbitrary URLs as favorites. You can't use this when the section is missing
- It makes the whole favorites concept a bit less discoverable. Until I notice an "add to favorites" command in a menu I might not know the feature exists. If I see the menu item, I might well wonder what that does because there is no sign of a favorites list.. user might think it just adds to browser favorites.

So, maybe if you have no favorites, the section should stay there, and just have a blurb explaining how to add them.

Comment 1 Susan McCourt

2012-05-14 11:10:31 EDT

thanks, John...this is under change right now, as we convert those LHS panes to use the explorer/selection model.  In fact, all commands will end up the section header at that point, based on selections made below.

In that world, we'll have a blurb explaining what you can do if it's empty.  
The only exception to this rule is File Servers.  If you just have one, you won't see that list.  Thinking here is that for many cases, the user only ever has one and we won't expose the concept.

Comment 2 Susan McCourt

2012-05-15 16:09:54 EDT

finally pushed this.
We now use the common section code and for favorites and searches, when they are empty, there is a blurb telling you how to get some.  We also remember the expand/collapse state of these sections now.