Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 37938

Summary: One-click search does not find e-fixes
Product: [Eclipse Project] Platform Reporter: Dejan Glozic <dejan>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Dejan Glozic <dejan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: birsan
Version: 2.1   
Target Milestone: 2.1.1   
Hardware: PC   
OS: All   
Whiteboard:

Description Dejan Glozic CLA 2003-05-21 15:01:58 EDT 
When one-click update search is used (Window->Software Updates->New Updates), 
it only finds 'true' updates (new versions of the currently installed 
features). Patches for the installed features are not included in the search.

This is counter-intuitive because the distinction is too fine for Eclipse 
product users. They expect to search for updates for their product and find 
both fix packs and emergency fixes (patches). The fact that they need to go to 
Update Manager for patches seems confusing to them.

One-click search should be modified to find patches as well.
Comment 1 Dejan Glozic CLA 2003-05-21 15:09:08 EDT 
Here is the proposed fix:

Update search algorithm will be modified to include not only features with 
higher versions but also those declared as patches to the initiator. Normally 
we would need to parse feature.xml in order to tell if a feature is a patch or 
not. This will make search slower since every feature JAR on the site will be 
downloaded in the process. Search performance can be improved 
if 'patch="true"/"false"' is placed in site.xml for each feature entry. 
Features that are not patches will be skipped in the search thus improving 
performance.

The algorithm change will be as follows:

1) Patches will be also added to the list of 'hits'
2) The top-most true update (if found) and all the matching patches will be 
reported as search results
3) Combined true updates (for all the local features) will be shown in the 
wizard list pre-checked (as today). Patches will not be pre-checked (we cannot 
assume that all the patches will be installed by default)
Comment 2 Dejan Glozic CLA 2003-05-21 15:10:19 EDT 
Change implemented. Dorian, please verify. To do so, compare 
org.eclipse.update.ui project for R2_1 version and R2_1_maintenance branch.
Comment 3 Dorian Birsan CLA 2003-05-21 16:30:17 EDT 
The code looks fine and also watched Dejan performing some testing to verify 
the fix.
+1
Comment 4 Dejan Glozic CLA 2003-06-09 17:13:48 EDT 
Fixed both in 2.1.1 and HEAD.