Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 379320

Summary:	styling issues with new command styling
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm
Version:	0.5
Target Milestone:	0.5 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-05-11 17:37:21 EDT

we are now styling commands with permanent button borders but we still have some issues to work out.  Either Anton or I will get to these soon, but I thought I should start a bug with a running list as I spot them:

- currently the related pages, chevrons, and command menus use the same styling.  Until we can get rid of chevrons and separate the styling, we left the borders off.  However what we want is that command menu buttons are bordered just like the other buttons, aligned properly, etc....  However related pages should retain its own style.  I took a quick pass at this but it was not a one-liner, because there are nested dijitButtonxxx spans on the related page menu...the border is coming from an inner span, not the toggle button itself.

- the favorites button now has an extra 5px margin because the sprite margins have been increased.  It also looks off center (the little star in the upper left of a big hover area).  We will want to give it its own style (and presumably we'll leave a border off of it).

Comment 1 Susan McCourt

2012-05-11 17:40:17 EDT

The progress messages are now bolded.  Was that intentional?

Comment 2 Susan McCourt

2012-05-21 14:31:10 EDT

(In reply to comment #0)
> - currently the related pages, chevrons, and command menus use the same
> styling.  Until we can get rid of chevrons and separate the styling, we left
> the borders off.  However what we want is that command menu buttons are
> bordered just like the other buttons, aligned properly, etc....  

I added the border to the command buttons now that we don't have the chevrons anymore.  I created a separate css class "bannerMenu" for menus that appear elsewhere (non-bordered.)

Comment 3 Susan McCourt

2012-05-21 16:20:17 EDT

(In reply to comment #0)
 
> - the favorites button now has an extra 5px margin because the sprite margins
> have been increased.  It also looks off center (the little star in the upper
> left of a big hover area).  We will want to give it its own style (and
> presumably we'll leave a border off of it).

I bumped into this while trying to fix slideout positioning.  I discovered a border-none had been added to the sprite class, which caused some shifting of slideout buttons on hover.  When I fixed this, a border appeared on the favorites button.  Presumably the sprite change was to eliminate the border in the banner, but it had rippling effects elsewhere.  I created a dedicated class, "bannerButton" that we can style for any buttons in the banner that don't conflict with the styles used in command framework, sprites, or layout.

I'll consider this fixed for now, and we can open new bugs on any issues we see with alignment, etc.