| Summary: | alignment issue in nav tree | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Susan McCourt <susan> | ||||
| Component: | Client | Assignee: | Susan McCourt <susan> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | antonm, ken_walker, libingw, simon_kaegi | ||||
| Version: | 0.5 | Flags: | simon_kaegi:
review+
|
||||
| Target Milestone: | 0.5 RC3 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
moving to RC2 for triage after the test pass. For some reason this is looking worse/more apparent with the new icons. I noticed it first when we got rid of the checkboxes in the selection model, but I'm not sure that is the cause. It's likely that some of our css margins, padding have changed over time but we haven't hit all the right places. Investigating impact on RC3 Fix pushed to remote branch origin/bug379143, commit is d4a2c7c287aea33570b7002fd9e3bd3902cc541b This problem has always been there, but started to look progressively worse as we removed checkboxes, made the model icons more uniform, etc. etc. The problem is the padding that we have around model decoration icons. The padding was there so that the hit area we have on desktops and ipads will adjust accordingly. But...when using an "img" node, to show the content type images, the padding (2px on desktop, 8px on smaller devices) is a proper padding, where the image is placed in a way that honors the padding. When using "span" node and a sprite, the sprite is placed with background position, the padding it not honored since the background is not the content. The fix is to use margin instead of padding in the classes that are showing a mix of sprites and images. There is probably a better fix later, but this is the most convservative... sigh, you also need b8f90a14de6a0b6cafc8c2e98e331610c108ba2f in the branch. The ipad case (screen 1024 or less) did not fix padding-left->margin-left. Verified on ipad. Retested on chrome, FF, ie9. This was pushed earlier today. Fixed. |
Created attachment 215410 [details] screenshot Now that the checkboxes are gone in the navigator, we have some alignment issues with the indentation. Some "peer children" in the tree are aligning differently. I saw this problem on both Chrome and FF.