Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 379143

Summary: alignment issue in nav tree
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: antonm, ken_walker, libingw, simon_kaegi
Version: 0.5Flags: simon_kaegi: review+
Target Milestone: 0.5 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
screenshot none

Description Susan McCourt CLA 2012-05-10 11:10:14 EDT
Created attachment 215410 [details]
screenshot

Now that the checkboxes are gone in the navigator, we have some alignment issues with the indentation.  Some "peer children" in the tree are aligning differently.  I saw this problem on both Chrome and FF.
Comment 1 Susan McCourt CLA 2012-06-06 18:00:12 EDT
moving to RC2 for triage after the test pass.
Comment 2 Susan McCourt CLA 2012-06-19 14:49:11 EDT
For some reason this is looking worse/more apparent with the new icons.  
I noticed it first when we got rid of the checkboxes in the selection model, but I'm not sure that is the cause.  It's likely that some of our css margins, padding have changed over time but we haven't hit all the right places.

Investigating impact on RC3
Comment 3 Susan McCourt CLA 2012-06-19 16:05:02 EDT
Fix pushed to remote branch origin/bug379143, commit is
d4a2c7c287aea33570b7002fd9e3bd3902cc541b

This problem has always been there, but started to look progressively worse as we removed checkboxes, made the model icons more uniform, etc. etc.

The problem is the padding that we have around model decoration icons.  The padding was there so that the hit area we have on desktops and ipads will adjust accordingly.  

But...when using an "img" node, to show the content type images, the padding (2px on desktop, 8px on smaller devices) is a proper padding, where the image is placed in a way that honors the padding.  

When using "span" node and a sprite, the sprite is placed with background position, the padding it not honored since the background is not the content.

The fix is to use margin instead of padding in the classes that are showing a mix of sprites and images.  There is probably a better fix later, but this is the most convservative...
Comment 4 Susan McCourt CLA 2012-06-19 16:23:04 EDT
sigh, you also need
b8f90a14de6a0b6cafc8c2e98e331610c108ba2f
in the branch.

The ipad case (screen 1024 or less) did not fix padding-left->margin-left.
Verified on ipad.
Retested on chrome, FF, ie9.
Comment 5 Simon Kaegi CLA 2012-06-19 21:46:37 EDT
This was pushed earlier today. Fixed.