Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 379041

Summary: cannot save changes to a site
Product: [ECD] Orion Reporter: Grant Gayed <grant_gayed>
Component: ClientAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: P3 CC: mamacdon
Version: 0.5   
Target Milestone: 0.5 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Grant Gayed CLA 2012-05-09 14:46:53 EDT 
On orion.eclipse.org

- create a new Site
- press its Convert to Self-Hosting button
- press its Save button
- note that the changes to the site are not saved, so the site cannot be started (at least not to self-host)
- no errors are written to the console
Comment 1 Mark Macdonald CLA 2012-05-09 20:43:32 EDT 
In commit ac67b8bb5b, SelectionRenderer was changed so that it injected DOM element references ('rowDomNode') into the model items that it renders. This broke the site editor, since it later tries to serialize those DOM nodes to JSON when you save. The save then silently fails and everything is screwed.

However, I see that this behavior has just been reverted by commit 0be9ae0e84. So the site editor should work again in tonight's build. Tomorrow I'll look into what the renderer's behavior should be and change the site editor accordingly if needed.

Also I opened bug 379070 for the lack of error reporting on the save.