Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 379038

Summary: textStylerOptions needs to be refactored
Product: [ECD] Orion Reporter: Simon Kaegi <simon_kaegi>
Component: ClientAssignee: Simon Kaegi <simon_kaegi>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Silenio_Quarti
Version: 0.5   
Target Milestone: 4.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Simon Kaegi CLA 2012-05-09 14:08:39 EDT 
textStylerOptions is in the editor bundle but is making use of functionality in the core bundle. This needs to be refactored out as it means this component cannot be used independent from the Orion plugin and services registry.

It looks like this was done to get at preferences and in particular preferences changes. Instead the code needs to be refactored so that another component informs the textStylerOptions instance of the change. Also, using orion/bootstrap in this code is dangerous because this creates a second and independent instance of the plugin and service registry. They happen to share the same data but events set in one are not seen by the other.
Comment 1 Simon Kaegi CLA 2012-05-16 17:38:19 EDT 
For M2 I've made it so the bootstrap is in effect a singleton so we don't initialize things twice. I'm going to hold onto and keep this bug open though as I think what we really want is to inject the settings/preferences right into this component instead of doing a service lookup and this bug is as good a place as any to start.
Comment 2 Silenio Quarti CLA 2013-09-11 13:13:30 EDT 
textStylerOptions.js has been refactored into the new editor theming API. The new API no longer uses the core bundle. See bug#401914.

textStylerOptions.js does not exists anymore.