Bugzilla – Full Text Bug Listing
| Summary: | "Open With > Other..." should allow to store as default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> | ||||
| Component: | IDE | Assignee: | Andrey Loskutov <loskutov> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | daniel_megert, Lars.Vogel, loskutov, milesparker, pwebster | ||||
| Version: | 3.8 | Keywords: | noteworthy | ||||
| Target Milestone: | 4.5 M7 | Flags: | daniel_megert:
pmc_approved+
|
||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=460555 https://git.eclipse.org/r/42388 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5f5655a94e574f0e4496f89a1506be82edd0ef2c https://git.eclipse.org/r/45499 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2b259c72877e72bbef6e020cf9a2b58b53f54c4c https://bugs.eclipse.org/bugs/show_bug.cgi?id=468906 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 463262, 486859 | ||||||
| Attachments: |
|
||||||
I have a fix, based on fixed dialog from bug 460555. Gerrit review follows. New Gerrit change created: https://git.eclipse.org/r/42388 Created attachment 251006 [details]
Updated dialog screenshot
Gerrit change https://git.eclipse.org/r/42388 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5f5655a94e574f0e4496f89a1506be82edd0ef2c . (In reply to Eclipse Genie from comment #4) > Gerrit change https://git.eclipse.org/r/42388 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5f5655a94e574f0e4496f89a1506be82edd0ef2c See http://download.eclipse.org/eclipse/downloads/drops4/N20150326-2000/apitools/freeze_report.html This change added new API. After M7 API changes, including additions, can only be added if approved by the PMC. Andrey, please quickly explain why the new API is needed or revert the changes. I filed bug 463262 to polish the radio button(s). (In reply to Dani Megert from comment #6) > (In reply to Eclipse Genie from comment #4) > > Gerrit change https://git.eclipse.org/r/42388 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5f5655a94e574f0e4496f89a1506be82edd0ef2c > > See > http://download.eclipse.org/eclipse/downloads/drops4/N20150326-2000/apitools/ > freeze_report.html > > This change added new API. After M7 API changes, including additions, can > only be added if approved by the PMC. > > Andrey, please quickly explain why the new API is needed or revert the > changes. > > I filed bug 463262 to polish the radio button(s). Oops, sorry, the change was made at M5 time. The EditorSelectionDialog.setFileName() is needed to allow us remember the editor mapping for the file name. (In reply to Andrey Loskutov from comment #7) > The EditorSelectionDialog.setFileName() is needed to allow us remember the > editor mapping for the file name. Approved. I added the change to the exception list. *** Bug 195596 has been marked as a duplicate of this bug. *** With I20150407-0800 (and probably from very beginning) the "Use for all "*.XYZ" files" setting is valid for the current Eclipse session ONLY, and lost after restart. New Gerrit change created: https://git.eclipse.org/r/45499 Gerrit change https://git.eclipse.org/r/45499 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2b259c72877e72bbef6e020cf9a2b58b53f54c4c (In reply to Eclipse Genie from comment #12) > Gerrit change https://git.eclipse.org/r/45499 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=2b259c72877e72bbef6e020cf9a2b58b53f54c4c Committers are not allowed to claim "greatfix"es. :-) Verified in I20150428-0800 |
The "Open With > Other..." dialog should allow me to store the selected editor as default for this file type. A problem is that the Editors > File Associations preferences allow two kinds of file name patterns: name.ext and *.ext. UI could look like this: <editors list> [Browse...] [ ] Always use this editor for: // checkbox; *unchecked* by default (o) *.ext ( ) name.ext // radios; first selected by default