Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 378092

Summary: use of toolbar in outline (aux) page, outline section rendering
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: antonm
Version: 0.5   
Target Milestone: 0.5 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
some trials... none

Description Susan McCourt CLA 2012-04-30 11:27:58 EDT 
We don't yet have a good story for how sections in the left hand side of navigator, editor, etc. show their headings, how they relate to the toolbar, etc.

In looking at all the pages with left hand sides,  it seems like we don't have any concrete examples where the left hand side as a whole would have commands on it.  So reserving toolbar space on the left hand side does not seem valid.  

We have some LHS pages with just one "section" and one could argue that any commands for that section (such as editor outliner, where the (optional) editor switcher could be considered a toolbar command) should be on the toolbar.  But that model quickly breaks down when you have multiple "sections" on the left hand side, like favorites, searches, file systems, etc.

I think we should remove the LHS toolbars and instead have a LHS section rendering that looks good for single and multiple sections.  The white shaded striped background we use now does not hold up nicely once you remove the toolbar, because it doesn't align with the right hand side toolbar.  If we had just a font/spacing rendering, it might look better.

This is impacting the nav LHS as I move content from the landing page to the nav.
Comment 1 Susan McCourt CLA 2012-04-30 13:04:22 EDT 
Created attachment 214812 [details]
some trials...

this snapshot is a composite that shows the problem, and some different ideas I tried in the CSS.  This is mostly to remember what the issues were before we started changing it.
Comment 2 Susan McCourt CLA 2012-04-30 16:19:02 EDT 
I've pushed a first set of changes that I think improves things, but it could still use polish.

- get rid of the left hand side toolbars in all pages that didn't need it.  This leaves git status as the only page with a left side toolbar.
- change section rendering in left hand (aux) panes to rely only on font size/padding vs. the "reverse section header" idea
- change the editor outliner to use the common code for pane headings and commands.  The most immediate thing to notice is that the editor outliner will have a heading "Outliner" and when you have more than one outliner, the switch menu is now rendered in the common way, rather than just dropping it into the editor content as done before.

Some bonus changes while working on the CSS and html for toolbars:
- fixed the claro overrides so that our command menus are the expected colors (the generated menus had the wrong foreground color)
- copy the accessibility fixes made by Max for generated drop down menus into the generated "choice callback" drop down menu.  This means that top level choice menus (such as the editor outliner switcher) will have the same accessibility fixes as the other dropdowns.
- all of the html pages were using the wrong toolbar class.  Changed "toolbar" to "mainToolbar".

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/diff/bundles/org.eclipse.orion.client.core/web/orion/commands.js?id=8dfd02c90be3d949edf546e6ab62ade79466e61e

I think everything looks much better than it did, but keeping it open for possible tweaking/polish.
Comment 3 Susan McCourt CLA 2012-05-11 17:20:49 EDT 
Added the section headers back vs. a discussion with Linda.  We stopped flushing the section header and offset it a bit from the top.  Also increased margins on each side.

Anton took a pass afterward to round the edges up a bit.