Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 378065

Summary:	[subwords] checking for word boundaries using upper case letters blows up for static constants and package proposals.
Product:	z_Archived	Reporter:	Deepak Azad <deepakazad>
Component:	Recommenders	Assignee:	Marcel Bruch <marcel.bruch>
Status:	CLOSED FIXED	QA Contact:
Severity:	minor
Priority:	P3	Keywords:	helpwanted
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Deepak Azad

2012-04-30 07:49:25 EDT

Define static constants like - COMPILER_PB_NULL_SPECIFICATION_VIOLATION

Comment 1 Marcel Bruch

2012-04-30 10:30:48 EDT

well, in this case it considers the whole sequence as one word. Is considering any non-word-character as word limiter (+uppercase letters) what you would expect?

Comment 2 Deepak Azad

2012-04-30 10:38:22 EDT

(In reply to comment #1)
> well, in this case it considers the whole sequence as one word. Is considering
> any non-word-character as word limiter (+uppercase letters) what you would
> expect?

Yup, we can consider underscore '_' as a word delimiter.

Comment 3 Marcel Bruch

2012-04-30 10:54:41 EDT

OK. I think this one is not a critical issue. We'll work on this after chain completion engine performance fixes.

Comment 4 Marcel Bruch

2012-04-30 10:59:38 EDT

Note to self:

Fixing this requires changes to LCSS#findSequences and related test classes.

http://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/tree/plugins/org.eclipse.recommenders.completion.rcp.subwords/src/org/eclipse/recommenders/internal/completion/rcp/subwords/LCSS.java

http://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/tree/tests/org.eclipse.recommenders.tests.completion.rcp/src/org/eclipse/recommenders/tests/completion/rcp/subwords/LCSSTest.java

http://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/tree/tests/org.eclipse.recommenders.tests.completion.rcp/src/org/eclipse/recommenders/tests/completion/rcp/subwords/SubwordsCompletionProposalComputerIntegrationTest.xtend

Comment 5 Marcel Bruch

2012-05-02 04:26:22 EDT

Similar issue for packages.

Dots as in "org.eclipse.swt" are ignored. Effectively only character sequences are checked.

Comment 6 Marcel Bruch

2012-05-13 03:01:20 EDT

Head update site contains a fix for constants and packages.

I'll test it a few more days to see if the new implementation is stable.

As side note: subwords starting with numbers are not supported ATM.

Comment 7 Marcel Bruch

2012-06-02 11:09:10 EDT

current version seems to work as expected.

Comment 8 Marcel Bruch

2012-06-09 15:12:10 EDT

Set target milestone for fixed bugs to 1.0

Comment 9 Marcel Bruch

2012-06-09 15:12:16 EDT

Set target milestone for fixed bugs to 1.0

Comment 10 Marcel Bruch

2012-07-01 05:38:31 EDT

Juno shipped, change was made. Closing this bug.