Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 377950

Summary:

Update JDT feature icon

Product:

[Eclipse Project] JDT

Reporter:

John Arthorne <john.arthorne>

Component:

Assignee:

Dani Megert <daniel_megert>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public, daniel_megert, markus.kell.r

Version:

3.8

Flags:

markus.kell.r: review+

Target Milestone:

3.8 RC1

Hardware:

OS:

Windows 7

Whiteboard:

Bug Depends on:

Bug Blocks:

341645

Attachments:

Description	Flags
New icons	none

Description John Arthorne

2012-04-27 13:28:42 EDT

The org.eclipse.jdt branding plugin needs the new Eclipse icons. It is located in git here:

repo=git://git.eclipse.org/gitroot/jdt/eclipse.jdt.git,path=org.eclipse.jdt

This is currently causing the old icon to still appear under Help>About.

Comment 1 John Arthorne

2012-04-27 13:31:44 EDT

Created attachment 214726 [details]
New icons

Comment 2 Markus Keller

2012-04-28 09:26:02 EDT

I can release these, but only if you also updates the other features in the 3.8 branch. In I20120427-1000 (3.8) all features still use the old icons, and it doesn't make sense to update JDT but not the SDK.

Bug 341645 comment 70 looks wrong, since it only touched the R4_HEAD branch, but not the master branch of features that should stay in sync in 3.8 and 4.2.

Comment 3 Markus Keller

2012-04-28 09:26:24 EDT

Comment 4 Dani Megert

2012-04-30 04:36:17 EDT

The question is whether the new icons are for 3.8 and 4.2 or only for 4.2. If the latter, then we won't change the icon and will provide the old one for 4.2, which I think is OK, given it is indeed the 3.8 code. Same procedure must be applied to PDE, CVS and Help.

Comment 5 John Arthorne

2012-04-30 09:29:30 EDT

The new icons and splash are only intended for the 4.2 stream. Personally I think it looks better for all features to have the same icon but if you don't want to branch I guess we can live with it for 4.2.

Comment 6 Dani Megert

2012-04-30 09:31:20 EDT

Comment 7 Dani Megert

2012-05-04 02:56:24 EDT

We decided to also use the new icons in 3.8 (see bug 378108 for details).

Comment 8 Dani Megert

2012-05-09 05:20:09 EDT

http://git.eclipse.org/c/jdt/eclipse.jdt.git/commit/?id=4b7e9b779c52568b785a24c01d0b79c15b5e9854

Comment 9 Dani Megert

2012-05-11 04:31:55 EDT

Verified in 4.2-I20120510-1900 and 3.8-I20120510-2100.