Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 377199

Summary: [Compare]Support deferred callback in startup function.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: susan, Szymon.Brandys
Version: 0.4   
Target Milestone: 0.5 M2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 376903    

Description libing wang CLA 2012-04-19 11:08:02 EDT
To render the contents of a compare widget, we always call widget.startup() function after it is instantiated.
We should either follow a widget.startup.then() pattern or just pass a callback in the startup function.
An example comes from the git commit page.
When there are multiple files modified in a commit, we want to create compare widgets after the previous one is completely loaded. By doing that, we are not leaving a number of blank widgets and waiting there for server response.
Comment 1 libing wang CLA 2012-04-19 11:14:23 EDT
Susan, Szymon, Gosia and I talked about this in the UI call yestoday.
I recalled that we kind of agreed that all the multiple section renderings that need server responses should follow the same pattern. Git repo page is already doing this? I don't remember how Szymon talked about this.