Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 377010

Summary:	compare - the "generate link" command should not be an icon, perhaps just a keybinding
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw, susan, Szymon.Brandys
Version:	0.5
Target Milestone:	0.5 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-04-17 13:26:58 EDT

per our command guidelines (Bug 360986 comment 29), most commands in section headers (pane headers) should be text.  The exception to this rule is when it's an arrow or other positional command for which text is harder to read than the arrow.

So the "generate link" command should be text.

However I'm wondering if it should even appear in the header at all.  It's a fairly advanced command and in its current form we don't have much room for commands in that pane (hopefully we can fix this in bug 349328).  

I suggest we make this a keystroke only command.  To me it's very similar to the other "advanced editor" commands that are keystroke only.  (We will need a story for tablet access, discovery, etc. but this is a general problem with keybinding only commands).

Comment 1 libing wang

2012-05-22 12:27:45 EDT

With git status2, we still want to be able to open the compare page to edit.
We can make an option so that the caller of the widget decide this "generate link" behavior : default is "generate  link", the option is the open compare page URL.

Comment 2 Susan McCourt

2012-05-22 12:53:11 EDT

I just made a similar remark in bug 377630 but I see it as the other way around, since there is really only one page where "generate link" makes sense.

So we could have an option to provide a link to the compare page in the commands.  And also that there should be a way for a client to get the URL of the current change.

Then the compare page could add its own "generate link" command at the page level.

Comment 3 libing wang

2012-05-22 17:23:59 EDT

The issue is resolved in 377630. Regarding the key bindings, we need to think about it in a broader way, not limited to this gen link command.

*** This bug has been marked as a duplicate of bug 377630 ***