Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 376900

Summary: Login Page opens in a new tab
Product: [ECD] Orion Reporter: Ian Skerrett <ian.skerrett>
Component: ClientAssignee: Project Inbox <orion.client-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: malgorzata.tomczyk, simon_kaegi
Version: 0.4   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Ian Skerrett CLA 2012-04-16 13:56:47 EDT
When I try to Sign-in to OrionHub, an new tab is opened?  I would expect to be using the same browser tab to sign-in.  The new Login page does not have any of the standard footer or header information.

btw, there is not a consistent use of terms either.  You select 'Sign In' from OrionHub and then sent to a Login page.
Comment 1 John Arthorne CLA 2012-04-17 11:41:29 EDT
This is a generic Orion issue and not specific to OrionHub. I know it was designed this way intentionally and for example GMail does the same thing. One advantage is that the user can see the domain name of the page asking for your password - some people would be uncomfortable feeding their password into a popup that could have been injected from another site.
Comment 2 Simon Kaegi CLA 2012-04-17 12:06:53 EDT
When we made the decision to authenticate in another window the idea was to come back and look at optimizing the same domain case but it never was highest on the priority list. Now that we're looking at usability we can and should revisit this.

On the flip side I'm expecting that things like OpenID, BrowserID, etc. will increasingly be our primary means of authentication for Orion and for these we might always be opening a new window and had better make the experience as painless as possible.
Comment 3 Ian Skerrett CLA 2012-04-17 12:41:27 EDT
(In reply to comment #1)
> This is a generic Orion issue and not specific to OrionHub. I know it was
> designed this way intentionally and for example GMail does the same thing. One
> advantage is that the user can see the domain name of the page asking for your
> password - some people would be uncomfortable feeding their password into a
> popup that could have been injected from another site.

When I login to GMail I stay on the same page.  I am not sure why you have to open a new tab to show the domain name?   Regardless, if you think opening a new tab is the correct thing, the page should be skinned properly.
Comment 4 Ian Skerrett CLA 2012-04-17 12:48:21 EDT
(In reply to comment #2)
> When we made the decision to authenticate in another window the idea was to
> come back and look at optimizing the same domain case but it never was highest
> on the priority list. Now that we're looking at usability we can and should
> revisit this.
> 
> On the flip side I'm expecting that things like OpenID, BrowserID, etc. will
> increasingly be our primary means of authentication for Orion and for these we
> might always be opening a new window and had better make the experience as
> painless as possible.

FWIW, I would imagine OrionHub will always have to have its own authentication mechanism.  We should optimize for some of the more common ones but there will always be people that won't want to use the more common ones.
Comment 5 Szymon Brandys CLA 2012-04-17 12:58:21 EDT
(In reply to comment #3)
> When I login to GMail I stay on the same page.  I am not sure why you have to
> open a new tab to show the domain name?   Regardless, if you think opening a new
> tab is the correct thing, the page should be skinned properly.

Because Orion allows to work with services (e.g. filesystems) from other domains and you are authenticating against these services not Orion itself. So you may have Orion on orionhub.org and filesystem service on ian.org plugged in to your browser. When you access orionhub.org and start working against ian.org filesystem, you should be aware of what domain you are authenticating against.
Comment 6 Szymon Brandys CLA 2012-04-17 13:00:57 EDT
(In reply to comment #2)
> On the flip side I'm expecting that things like OpenID, BrowserID, etc. will
> increasingly be our primary means of authentication for Orion and for these we
> might always be opening a new window and had better make the experience as
> painless as possible.

I would focus on OpenId authentication with a new window open and would not spend time on handling form authentication for services in the same domain.
Comment 7 Malgorzata Janczarska CLA 2012-04-17 13:07:47 EDT
(In reply to comment #3)
> When I login to GMail I stay on the same page.
If you haven't been already logged in to GMail you will always be redirected to GMail page.
Comment 8 Ian Skerrett CLA 2012-04-17 13:36:46 EDT
(In reply to comment #5)
> (In reply to comment #3)
> > When I login to GMail I stay on the same page.  I am not sure why you have to
> > open a new tab to show the domain name?   Regardless, if you think opening a new
> > tab is the correct thing, the page should be skinned properly.
> 
> Because Orion allows to work with services (e.g. filesystems) from other
> domains and you are authenticating against these services not Orion itself. So
> you may have Orion on orionhub.org and filesystem service on ian.org plugged in
> to your browser. When you access orionhub.org and start working against ian.org
> filesystem, you should be aware of what domain you are authenticating against.

From an end user perspective I am not sure why when a login to OrionHub I need to worry about where my filesystem is located?   From an initial user experience, I am assuming OrionHub has figured this out for me.   If a more advanced option allows for a filesystem to be in another domain, handle that not at initial login but at a different place.
Comment 9 John Arthorne CLA 2015-05-05 14:39:54 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html