Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 376772

Summary: [Compare]Annotation orders against syntax highlighting.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 0.4   
Target Milestone: 0.5 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2012-04-13 14:54:41 EDT 
Sometimes syntax highlighting is racing with diff annotations. Rare case but it did happen.
The diff annotation creation assumes that syntax highlighting already happened before but it was async call. So sometimes it hides the diff annotations.
The URL below is an example: the word diff is not visible because there is a syntax highlighted at the same place.


http://libingw.orion.eclipse.org:8080/compare/compare.html?readonly#/gitapi/diff/7735e5595dd31b266d43fd87890d24a55d5c33bc..de5e660f40b2a607645a163d254809a993375bd1/file/B2/bundles/org.eclipse.orion.client.core/web/plugins/pageLinksPlugin.html,block=1


SyntaxHighlighter.setUp() has a deferred call so I think we should render annotations in the deferred call.

But I don't think it will be a perfect solution if other highlighters implement their annotations or stylers in a different way.

We should consider using z-order of annotations.
Comment 1 libing wang CLA 2012-05-18 09:35:08 EDT 
fixed by using SyntaxHighlighter.setUp(callBack).