Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 376671

Summary: DBCS4.2 DBCS chars are garbled in folder name and file name.
Product: [ECD] Orion Reporter: Kentaroh Noji <kennoji>
Component: EditorAssignee: Ken Walker <ken_walker>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: camle, harendra, kennoji, ken_walker, kitlo, libingw, maedera
Version: 0.4   
Target Milestone: 0.5 RC1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
DBCS chars are garbled. none

Description Kentaroh Noji CLA 2012-04-12 20:52:27 EDT
Created attachment 213944 [details]
DBCS chars are garbled.

OS: Windows 7 SP1 Professional Japanese Edition

Steps to recreate problem:
1- Login orion.eclipse.org with user id and password provided. 
2- Click "Navigator". 
3- Click "New folder" and enter DBCS chars such as "漢字" in new folder input field.
4- Then, submit. The DBCS chars of folder name are garbled. The same symptom happens in file name. 

Additional information for the problem determination:
When I browse the HTML source file of Navigator, I found that the charset was ISO-8859-1, and this is for only Latin 1 characters. For globalization, using UTF-8 for charset is recommended. UTF-8 charset covers all Unicode characters including Latin 1, Japanese, Korean, Chinese, Arabic, Hebrew, Greece, Devanagari etc.  

Here is extraction from the HTML source: 
<meta http-equiv="Content-Language" content="en-us">
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">

This should be: 
<meta name="copyright" content="Copyright (c) IBM Corporation and others 2010." >
<meta http-equiv="Content-Language" content="en-us">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

When Orion's UI is translated, the content="en-us" should be changed in to each translated language id.
Comment 1 libing wang CLA 2012-04-24 15:01:14 EDT
I was able to reproduce it in my English Windows 7 with Japanese IME input.
Comment 2 Ken Walker CLA 2012-05-14 08:58:41 EDT
Will continue to investigate this week
Comment 3 libing wang CLA 2012-05-18 09:41:28 EDT
talked to Ken. He will continue the investigation.
Comment 4 Ken Walker CLA 2012-05-23 15:43:24 EDT
The data is being passed correctly it seems in the xhrDelete() from the client side Orion code.  Will now have to look at what is happening on the server.
Comment 5 Ken Walker CLA 2012-05-24 11:25:49 EDT
Moving this out to RC1 due to time constraints
Comment 6 Ken Walker CLA 2012-06-05 10:51:42 EDT
This requires changes on both server and client side.  For the most part the summary is that XHRs within the client side API were not setting the content type as UTF-8 and the Orion server file Servlet was not looking at the posted payload for the filename.  Instead it was using the SLUG and that is always in 8859_1 I believe.

Will open bugs for other DBCS issues I am seeing but will release changes for this particular defect.
Comment 8 Ken Walker CLA 2012-06-05 17:16:37 EDT
Fixes should be in tonights build
Comment 9 Kentaroh Noji CLA 2012-06-11 23:07:35 EDT
I verified that the orion server as of 2012-06-12 fixed this problem. The server can handle Unicode character successfully. However, I have a concern.  The page source file still specifies "charset=ISO-8859-1" in the meta tag as follows. 

<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
		<title>Navigator</title>

If possible, could you change the charset from ISO-8859-1 to UTF-8 to avoid a potential problem, please.