Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 376475

Summary: [CSSSpy] processor causes duplicate Copy keybinding
Product: [Eclipse Project] e4 Reporter: Paul Webster <pwebster>
Component: UIAssignee: Brian de Alwis <bsd>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: bsd, ob1.eclipse
Version: 0.12   
Target Milestone: 0.12 M7   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Paul Webster CLA 2012-04-11 07:04:00 EDT
The css spy model processor creates its own binding table, where the element Id doesn't match the context id (and it's for an already provided table, dialogAndWindows).  The binding tables need to have their element id match their context id.

PW
Comment 1 Paul Webster CLA 2012-04-26 06:32:52 EDT
Brian, can you look at this for M7?  It makes CSS Spy unusable.

PW
Comment 2 Brian de Alwis CLA 2012-04-26 09:31:01 EDT
Fixed in master (commit 2cdbb78665fcfe7e24ce192d318b5459d372875f)
Comment 3 Brian de Alwis CLA 2012-04-26 16:56:56 EDT
I'm going to re-open this as anywhere the spy has been installed now has a stray binding table, and will continue to bring up the strange keyboard shortcut popups. The SpyInstaller should remove any such binding tables found.
Comment 4 Brian de Alwis CLA 2012-05-02 12:43:12 EDT
Added code to check for and remove the incorrect table if found.  This will fix existing installations.

Fixed in master (commit 91ad0a19b056e0a07344f58497c4564a522496b5)
Comment 5 Carsten Reckord CLA 2012-10-26 12:54:13 EDT
A client of us is having issues with this. Judging by his metadata and configuration, he had CSS Spy installed at some time and tried to uninstall it (i.e. the feature is gone in the installation details, but the bundle isn't). Now he starts seeing the conflict after having installed apparently unrelated features. Any ideas on that?

Here's the related bindings from workbench.xml:

<bindingTables xmi:id="_j7ymwh0KEeKxccjpdbD97g" contributorURI="platform:/plugin/org.eclipse.ui.workbench" bindingContext="_j7ymxh0KEeKxccjpdbD97g">
    ...
    <bindings xmi:id="_j9Lt4R0KEeKxccjpdbD97g" keySequence="CTRL+SPACE" command="_j8g_lx0KEeKxccjpdbD97g"/>
    ...
</bindingTables>
<bindingTables xmi:id="_j9vHgh0KEeKxccjpdbD97g" elementId="bt.org.eclipse.e4.css.OpenSpy" bindingContext="_j7ymxh0KEeKxccjpdbD97g">
    ...
    <bindings xmi:id="_rfS0cR0KEeK6bpvMugz26A" keySequence="CTRL+SPACE" command="_j8g_lx0KEeKxccjpdbD97g"/>
    ...
</bindingTables>

The bundle still in his install is
org.eclipse.e4.tools.css.spy (0.12.0.v20111206-2146) "CSS Spy" [Active]