Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 376321

Summary:	GitTagHandler broken by API change in JGit
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Git	Assignee:	John Arthorne <john.arthorne>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	P3	CC:	tomasz.zarna
Version:	0.4
Target Milestone:	0.5 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2012-04-09 09:59:22 EDT

JGit changed the API signature of TagCommand.call(). It used to return a RevTag but now returns a Ref. This caused a compile error in Orion's GitTagHandlerV1.java.

    [javac] 154. ERROR in /opt/public/eclipse/e4/orion/I201204082230/plugins/org.eclipse.
er/git/servlets/GitTagHandlerV1.java (at line 135)
    [javac]     return git.tag().setObjectId(revCommit).setName(tagName).call();
    [javac]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    [javac] Type mismatch: cannot convert from Ref to RevTag

Comment 1 John Arthorne

2012-04-09 10:02:55 EDT

I have pushed a fix for this but I would like Tomasz to verify it:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=d3ad9ac2a16694d3c440cd13b9cfcbefc59591cd

Comment 2 Tomasz Zarna

2012-04-16 08:41:07 EDT

Looks good, thanks for fixing this John.

For the record, it was caused by bug 360650.